search

harvimt / quamash

Implementation of the PEP 3156 event-loop (asyncio) api using the Qt Event-Loop
BSD 2-Clause "Simplified" License
265 stars 46 forks source link

Do not meddle with the PyQt namespace #57

Closed sbourdeauducq closed 8 years ago

sbourdeauducq commented 8 years ago

i.e. remove this: https://github.com/harvimt/quamash/blob/master/quamash/__init__.py#L52

sbourdeauducq commented 8 years ago

Well, the hack is still there. Is it absolutely necessary?

harvimt commented 8 years ago

No. It's been fixed in another branch for a while.

Also it's like the least ugly hack in quamash.

On Mon, Dec 14, 2015 at 4:17 PM, Sébastien Bourdeauducq < notifications@github.com> wrote:

Well, the hack is still there. Is it absolutely necessary?

— Reply to this email directly or view it on GitHub https://github.com/harvimt/quamash/issues/57#issuecomment-164601609.

sbourdeauducq commented 8 years ago

Can you please point to the branch you are referring to?

harvimt commented 8 years ago

depinject5realz I think. It's in a PR, and it needs to be rebased off master.

On Mon, Dec 14, 2015 at 5:54 PM, Sébastien Bourdeauducq < notifications@github.com> wrote:

Can you please point to the branch you are referring to?

— Reply to this email directly or view it on GitHub https://github.com/harvimt/quamash/issues/57#issuecomment-164617817.