search

harvimt / quamash

Implementation of the PEP 3156 event-loop (asyncio) api using the Qt Event-Loop
BSD 2-Clause "Simplified" License
265 stars 46 forks source link

Added Python 3.6 to CI #76

Closed Korijn closed 7 years ago

Korijn commented 7 years ago

Resolves #72

Korijn commented 7 years ago

Rebased on master.

harvimt commented 7 years ago

You need to download the PyQt 5.5

by modifying: https://github.com/harvimt/quamash/blob/master/.travis.yml#L14 as well as the md5sum

harvimt commented 7 years ago

Actually, it looks like PyQt5.5 is available as a wheel on PyPI for Python 3.5, so it can just be pip installed. Older versions of PyQt are not available as wheels though.

We can build our own wheel for py 3.6 and put it in the wheelhouse directory, (like I did for PySide).

harvimt commented 7 years ago

I bet the wheels are statically linked to so we don't need to apt-get install qt5

harvimt commented 7 years ago

nm again, PyQt 5.9 is available as a "manylinux" py 3.5,3.6,3.7 multi-wheel

https://pypi.python.org/pypi/PyQt5/5.9

Korijn commented 7 years ago

That would mean dropping support for Python 3.3 and 3.4 then? I'll try and extend the current approach a bit more, before I totally swing everything around...

Korijn commented 7 years ago

Python 3.4, 3.5 and 3.6 passed now. Python 3.3 seems to fail because PyQt5 doesn't support it anymore. Should we follow suit and drop it?

harvimt commented 7 years ago

I think the python foundation dropped support for python 3.3 as well (as in it's not receiving even security patches), so that's probably a good call.

On Aug 14, 2017 03:00, "Korijn van Golen" notifications@github.com wrote:

Python 3.4, 3.5 and 3.6 passed now. Python 3.3 seems to fail because PyQt5 doesn't support it anymore. Should we follow suit and drop it?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/harvimt/quamash/pull/76#issuecomment-322150468, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHRQsCSKsEIgvSc0V0QUlHn7FeS_8Cxks5sYBrCgaJpZM4O0TmU .

Korijn commented 7 years ago

I'm OK with merging this.

harvimt commented 7 years ago

Alright, to actually update the little badge, the trove specifiers in setup.py need to be changed.

Then the version needs to be bumped (with a change log entry in the README).

Then I can upload a new version to PyPI and then supported versions will be updated.