search

harwey / cups4j

Cups4j Java printing library for CUPS/IPP
http://cups4j.org
GNU Lesser General Public License v3.0
130 stars 64 forks source link

[master]: Apache HttpClient will set Host header automatically #42

Closed jordi-farre closed 3 years ago

jordi-farre commented 3 years ago

The intention of this change is to remove the configurable host header via properties. After removing this Apache HttpClient will calculate this header automatically. I have tested this enabling Apache HttpClient logs with this result:

2020/11/19 08:46:40:487 CET [DEBUG] headers - http-outgoing-0 >> Content-Type: application/ipp 2020/11/19 08:46:40:487 CET [DEBUG] headers - http-outgoing-0 >> Host: localhost:631 2020/11/19 08:46:40:487 CET [DEBUG] headers - http-outgoing-0 >> Connection: Keep-Alive

Thanks!

harwey commented 3 years ago

Thanks, I will check this on my system and will soon release a new version of cups4j, as this is a bug fix many people will need.

jordi-farre commented 3 years ago

Thanks for merging the change @harwey. The release will be generated automatically? Thanks.

shyamsundar18 commented 3 years ago

@harwey Can you publish this fix with 0.7.8 to the maven repository?

AnantAgarwal005 commented 3 years ago

@harwey Could you please release this fix ?