Add state machine - Githubissues

has-friendship / has_friendship

Add friendship to ActiveRecord models

MIT License

198 stars 98 forks source link

Add state machine #27

Closed ArmandoMendoza closed 8 years ago

ArmandoMendoza commented 8 years ago

Hi @sungwoncho , I added a new generator to create the migrations for update the friendships table. The migration make the change necessary in the data of table.

coveralls commented 8 years ago

Coverage increased (+0.02%) to 99.781% when pulling 252ae4e275d668e44158a72e841b745908cd26ac on ArmandoMendoza:add_state_machine into dd1e34bf90f621962ca7e9c636e89bbf7bc3b4a9 on sungwoncho:master.

sungwoncho commented 8 years ago

Thanks for the fix.

We should probably revert this line back to what it was.
We should generate the new migration file when people run rails generate has_friendship. Otherwise new users using 0.1.4 will have to run rails generate has_friendship and rails generate has_friendship_update to set up the tables. You can add a line after here.

sungwoncho commented 8 years ago

ping @ArmandoMendoza. Just want to see if you have some spare time to implement the fix. Thanks.

ArmandoMendoza commented 8 years ago

@sungwoncho sorry for the delay. I was full of work.

coveralls commented 8 years ago

Coverage increased (+0.02%) to 99.782% when pulling df3713520d31e1954621879fc56089b4bfb0e65f on ArmandoMendoza:add_state_machine into dd1e34bf90f621962ca7e9c636e89bbf7bc3b4a9 on sungwoncho:master.

sungwoncho commented 8 years ago

Thanks. Released as 1.0.0 because people need to run a migration. From now on, I will bump the major version whenever a new migration is added.