search

has-friendship / has_friendship

Add friendship to ActiveRecord models
MIT License
198 stars 98 forks source link

Run callbacks on state change #41

Closed sbadura closed 7 years ago

sbadura commented 7 years ago

Add ability to create own callbacks.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.003%) to 99.789% when pulling 9a3a794596270a5e4c3ce6e0074dee4f340b5c4d on sbadura:master into 2718e53be4f770dbb0465a135072f13d2ce70f49 on sungwoncho:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.003%) to 99.789% when pulling e5fd7b25f51f15622ec8fcccc1872e49b9ff747c on sbadura:master into 2718e53be4f770dbb0465a135072f13d2ce70f49 on sungwoncho:master.

temkin commented 7 years ago

@sungwoncho could you accept this PR?

sungwoncho commented 7 years ago

@temkin sorry for the delay.

This looks useful. @sbadura would you mind adding a test and document it in the README for those wanting to use this feature?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.01%) to 99.796% when pulling 7afc5f118c6ac2bc8b720d2c0001e34664bf62a4 on sbadura:master into 2718e53be4f770dbb0465a135072f13d2ce70f49 on sungwoncho:master.

sbadura commented 7 years ago

@sungwoncho Done :)

sungwoncho commented 7 years ago

Released in v1.1.0. ping @temkin.

Thanks for the PR.

temkin commented 7 years ago

@sungwoncho thank you!