search

has2k1 / mizani

A scales package for python
https://mizani.readthedocs.io
BSD 3-Clause "New" or "Revised" License
49 stars 14 forks source link

Missing dependencies: dateutil and docs/test dependencies #19

Closed juliangilbey closed 3 years ago

juliangilbey commented 3 years ago

Hi! Another missing dependency issue (like https://github.com/has2k1/plydata/issues/25). In addition to the docs/test dependencies not listed in setup.py, I see that dateutil is imported by mizani/transforms.py, but is not listed in setup.py. In the test suite, the package pytz is also used. I'm looking forward to using plotnine :-) Best wishes!

juliangilbey commented 3 years ago

Oh, and another one: scipy is imported in mizani/transforms.py, so needs to be added as well.

has2k1 commented 3 years ago

dateutil is brought in by Matplotlib (I think), but I guess it is proper to be explicit about it as a requirement.

For scipy, it should be in the extra_requires at the minimum.

On Wed., Feb. 10, 2021, 11:53 a.m. Julian Gilbey, notifications@github.com wrote:

Oh, and another one: scipy is imported in mizani/transforms.py, so needs to be added as well.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/has2k1/mizani/issues/19#issuecomment-776547090, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF6QNOGB3XKPP34AC5W3NTS6JCQJANCNFSM4XMLPHIA .

has2k1 commented 3 years ago

I see you have filled a bunch of issues but for now my involvement is limited. My ISP has blocked me from accessing github.

On Thu., Feb. 11, 2021, 9:26 p.m. Hassan Kibirige, has2k1@gmail.com wrote:

dateutil is brought in by Matplotlib (I think), but I guess it is proper to be explicit about it as a requirement.

For scipy, it should be in the extra_requires at the minimum.

On Wed., Feb. 10, 2021, 11:53 a.m. Julian Gilbey, < notifications@github.com> wrote:

Oh, and another one: scipy is imported in mizani/transforms.py, so needs to be added as well.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/has2k1/mizani/issues/19#issuecomment-776547090, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF6QNOGB3XKPP34AC5W3NTS6JCQJANCNFSM4XMLPHIA .

juliangilbey commented 3 years ago

You're right about dateutil! Sorry about your ISP - that's crazy. I hope you get it sorted!

juliangilbey commented 3 years ago

I'm less sure about scipy though - it's used by logit_trans and probit_trans, and the import in probability_trans is not protected in a try/except block.