has2k1 / plotnine

A Grammar of Graphics for Python
https://plotnine.org
MIT License
4k stars 213 forks source link

Make cmap_name the colormap for scale_color_cmap_d #693

Closed adunmore closed 1 year ago

adunmore commented 1 year ago

Fixes #691

Updated to same behavior as scale_color_cmap

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (2405442) 0.00% compared to head (c4993e3) 0.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #693 +/- ## ===================================== Coverage 0.00% 0.00% ===================================== Files 165 165 Lines 10666 10666 ===================================== Misses 10666 10666 ``` | [Impacted Files](https://app.codecov.io/gh/has2k1/plotnine/pull/693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hassan+Kibirige) | Coverage Δ | | |---|---|---| | [plotnine/scales/scale\_color.py](https://app.codecov.io/gh/has2k1/plotnine/pull/693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hassan+Kibirige#diff-cGxvdG5pbmUvc2NhbGVzL3NjYWxlX2NvbG9yLnB5) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

has2k1 commented 1 year ago

@adunmore, Thank you.