Closed penguinpee closed 10 months ago
I was able to downgrade mizani to 0.9.3 in order to satisfy the requirement of plotnine.
I'd still be interested in a patch to make it work. But I can also wait for the next release of plotnine, which most likely will support mizani >=0.10.0.
A patch is not a good idea, mizani-0.10.0 is a has significant cant API changes and it would big mismatch.
All right. I'll leave things as they are right now. We have mizani 0.9.3 and plotnine 0.12.3 available in Fedora.
It seems I wasn't paying enough attention when updating packages in Fedora. I just realized that plotnine 0.12.3 has:
https://github.com/has2k1/plotnine/blob/d1f7dbfb8ee209dadf33b26221ba3b00e10f7d9e/pyproject.toml#L27
But I already updated mizani to 0.10.0 in two branches. One being the upcoming release, Fedora 39. Could I just lower the constraint to
"mizani>0.9.0,<=0.10.0"
? Or is that known to break things? During build I saw one test failing related to mizani:I saw that in master https://github.com/has2k1/plotnine/commit/bb3f84b366e93081b3679e0695f877bec6d76f71 bumped that to:
https://github.com/has2k1/plotnine/blob/ef5650c4aabb29dcfe810043fb0fc8a4ea83f14b/pyproject.toml#L26
I'm wondering if I need to apply a patch to make 0.12.3 work with mizani 0.10.0.