search

has2k1 / scikit-misc

Miscellaneous tools for data analysis and scientific computing
https://has2k1.github.io/scikit-misc/stable
BSD 3-Clause "New" or "Revised" License
37 stars 9 forks source link

No changelog for 0.2.0 release #23

Closed penguinpee closed 1 year ago

penguinpee commented 1 year ago

I have been notified of the latest release (0.2.0) on PyPI. However, there's no changelog entry. I believe the switch to Meson deserves some mention. I haven't tried building 0.2.0 yet. Time permitting, I will look into this over the weekend.

penguinpee commented 1 year ago

The installation instructions probably also need to be adopted.

penguinpee commented 1 year ago

Hmm. The new release tarball on PyPI uses and underscore instead of a dash (scikit_misc vs. scikit-misc). Is there any particular reason for that change?

Not sure if this should go in a separate issue. Let me know and I'll open another one.

has2k1 commented 1 year ago

The new release tarball on PyPI uses and underscore instead of a dash (scikit_misc vs. scikit-misc)

That is due to a change in how the package is built. Switched to https://github.com/pypa/build, which creates the source distribution first and then builds the wheel from it. I guess, since wheels must use underscores the source distribution is created with an underscore too. I am not sure if this agreement between the two is part of a PEP standard!

has2k1 commented 1 year ago

The installation instructions probably also need to be adopted.

Thank you. I missed those.

has2k1 commented 1 year ago

I have been notified of the latest release (0.2.0) on PyPI. However, there's no changelog entry. I believe the switch to Meson deserves some mention. I haven't tried building 0.2.0 yet. Time permitting, I will look into this over the weekend.

There is a changelog. The documentation is lagging a bit.

penguinpee commented 1 year ago

I am not sure if this agreement between the two is part of a PEP standard!

Neither am I. Let me ask the Fedora Python list. It's not really an issue, more nuisance, since the naming guidelines require me to use dashes.

There is a changelog. The documentation is lagging a bit.

I see. It's there now. Thank you.

I switched the Fedora package to Meson over the weekend. Haven't pushed the update yet. It was a bit of work, but it looks fine now. One thing I noticed is the absence of tests. Is that planned for an upcoming release?

penguinpee commented 1 year ago

I guess, since wheels must use underscores the source distribution is created with an underscore too.

Actually, where does it say that wheels need to use underscores? I just realized that what you are using is the standard Python build command. I've used that before and Fedora uses it for Python packages to create wheels and not having underscores in the package names is not an issue.

Also in pyproject.toml name is set to scikit-misc (with a dash).

I'm sure I'm missing something. Just wanna check before forwarding the question.

has2k1 commented 1 year ago

Actually, where does it say that wheels need to use underscores?

PEP 427 dictates that the distribution name scikit-misc becomes scikit_misc.

has2k1 commented 1 year ago

One thing I noticed is the absence of tests.

The tests are in the sub-package.

penguinpee commented 1 year ago

PEP 427 dictates that the distribution name scikit-misc becomes scikit_misc

Thanks. I must have been confused by sub packages. So, underscore it is. Not a problem.

The tests are in the sub-package

I saw that. But now that the build is driven by Meson, I should be able to run meson test for the tests to be executed. However, that comes back with:

ninja: no work to do.
No tests defined.
eli-schwartz commented 1 year ago

I saw that. But now that the build is driven by Meson, I should be able to run meson test for the tests to be executed. However, that comes back with:

Not necessarily... the meson.build doesn't implement meson's own test() function. This project does use spin though, which powers the make test target of the Makefile.

Under the hood it's just running pytest skmisc with the PYTHONPATH set up to a staging install.

penguinpee commented 1 year ago

Under the hood it's just running pytest skmisc with the PYTHONPATH set up to a staging install.

Yeah. I saw that. In the last realease, which was still using Python tools, I had it set up in a special way due to RPM build environment. I guess I tripped over something else and then tried the direct approach using meson test. I have it fixed no and tests are being run once again. Thanks for being my (rubber) :duck: @eli-schwartz :wink:.

An updated Fedora package will be pushed shortly. Thank you all for the assistance and clarification. I'll close the issue.