search

hasadna / Open-Knesset

A project aimed at making the Israeli Knesset more transparent. Python and Django based
http://oknesset.org/
BSD 3-Clause "New" or "Revised" License
106 stars 175 forks source link

Facebook/twitter specific page metadata (next step with sharing) #670

Open alonisser opened 8 years ago

alonisser commented 8 years ago

Currently sharing Oknesset on facebook/twitter only shares the main page and in facebook fallbacks to the default oknesset main page link

In this step we'll add the following functionality: sharing Bills/Mks/Committees/Tags/Parties would have specific text and perhaps specific image for sharing, and would return to the specific link

Technical implementation: Overriding the "social_share" block from site_base for specific pages Can be implemented partly also (only for bills, only for mks, etc)

yotammanor commented 7 years ago

@alonisser does this Django package seem legit to you:

https://django-meta.readthedocs.io/en/latest/index.html

(it does to me, and seems to abstract away meta tags, but I'd love a second opinion before I add yet another dependency to Open Knesset's code).

yotammanor commented 7 years ago

@alonisser ping on the question above :)

alonisser commented 7 years ago

@yotammanor looks good, I'm inclined into using the model option, (from the two options suggested there) but your decision to make.

OriHoch commented 7 years ago

@yotammanor @alonisser deployed, please test (v4.6.0)