0 נוכחות במשכן

[maryLoi]

לח"כים הבאים יש 0 נוכחות במשכן, למרות שיש יש להם נוכחות חיובית בוועדות ציפי לבני , אבי דיכטר, בני בגין ויואל חסון

https://oknesset.org/member/213 https://oknesset.org/member/771 https://oknesset.org/member/14 https://oknesset.org/member/772

[OriHoch]

אין קשר בין נוכחות במשכן ונוכחות בועדות נוכחות במשכן זה תהליך אחר שלפי דעתי יש איתו הרבה בעיות..

@alonisser - do you remember if it's supposed to work automatically?

[maryLoi]

ציינתי את הנוכחות בוועדות כראיה לכך שהבעיה בדאטה ולא בגלל שהם באמת נעדרו לחלוטין מהמשכן

[OriHoch]

I added an issue in knesset-data to have this data available there - hasadna/knesset-data-python#15

[alonisser]

@OriHoch Actually it worked quite well for the past half year.. I'll investigate if something new is broken

[alonisser]

@maryLoi baahh a data problem . zipi livni (and I guess the others too) have an "end_date" to their knesset tenure . our presence parser (which processes the raw data, which is correct for her) check for end date for looping.. so removing the end date would solve this (and probably other problems as well)

[alonisser]

@OriHoch Also I think the check for endDate is a completely premature and unneeded optimization since we only check for current members any way (is_current) so I'm also removing it

[alonisser]

Opened a technical issue in #828 and pushed a PR with a fix

[maryLoi]

@alonisser what was the "end_date" intended for?

[alonisser]

wrong modeling I believe, didn't take into consideration that sometimes they return. But since I already optimized the query to take only "current" mks this isn't a relevant check

[maryLoi]

so the data in redash is also fixed? can I run the query again?

[alonisser]

Not yet. I pushed a fix to code, not into server, Until reviewed merged and deployed first you'll need to remove end_date from those mks through admin. Then you'll need to let it run, supposedly it would be fixed for 2017, Or I'll run manually to fix since beginning of current knesset. Update me when removed and we'll move forward

[OriHoch]

regarding the end date - in general, open knesset was intended only for current knesset.. so maybe it makes sense in that context (but still wrong..)

[maryLoi]

@alonisser what do you mean by "remove end_date from those mks through admin"? Ori said he doesn't know either

[alonisser]

@maryLoi see the picture.. Lets move the discussion to slack for further questions

[OriHoch]

@maryLoi what's the status? have you removed the end date?

[alonisser]

Fixed in previous PR and data migrated for the past

[OriHoch]

added to next draft release notes

[alonisser]

I solved without the end date.. so Can be closed

On Sun, Jul 9, 2017 at 11:55 AM Ori Hoch notifications@github.com wrote:

added to next draft release notes

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/hasadna/Open-Knesset/issues/826#issuecomment-313907658, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXlcEc3VQYg8AMErjySbVCI_I8ORzknks5sMJWKgaJpZM4NVJFj .

-- Alon Nisser twitter:@alonisser https://twitter.com/alonisser Facebook https://www.facebook.com/alonisser Tech Blog: https://medium.com/@alonisser/ Personal Blog:degeladom.wordpress.com Tel:972-54-6734469

[OriHoch]

yes, it's still closed, I haven't re-opened it, just wrote in the release notes