search

hasadna / Open-Knesset

A project aimed at making the Israeli Knesset more transparent. Python and Django based
http://oknesset.org/
BSD 3-Clause "New" or "Revised" License
106 stars 175 forks source link

Certain mk presence was not calculated due to redundant and deprecated check in presence parsing fails on certain mks #828

Closed alonisser closed 7 years ago

alonisser commented 7 years ago

Presence parsing (mishkan) was using a redundant and deprecated check if presence should be calculated to a period to mk. this check (mk end_date) is wrong since only "is_current" mks are being processed for presence. and "end_date" for mk is deprecated. (mks can return to knesset after "ending" a previous tenure)

OriHoch commented 7 years ago

after PR #830 is merged - I assume it will only be fixed for future data

do we need to run anything to re-scrape / re-calculate old data?

alonisser commented 7 years ago

It would update automatically for 2017, after deploy I need to do something manually on the server to update the periods before

OriHoch commented 7 years ago

@alonisser what's the status? should I assign for someone else to complete this for the hackathon (which is starting today..)

OriHoch commented 7 years ago

related but not contradicting issue: hasadna/knesset-data-python#15

alonisser commented 7 years ago

@OriHoch as I said it needs to be deployed and then I can run the fix.. was it deployed? the issue was not updated with a deploy

alonisser commented 7 years ago

@OriHoch Also not merged. .. so why the status question? After merge and deploy 2017 would be fixed automatically and I need to do something manual (completely manual.. ) to update 2016-2015

OriHoch commented 7 years ago

I was waiting for you to merge and deploy it.. but I guess we had a misunderstanding.. no problem, I'll merge

OriHoch commented 7 years ago

deployed, please test

alonisser commented 7 years ago

WIll do. later today

alonisser commented 7 years ago

Confirmed working, now running 2015-2016 also (And clean web python cache to see results. would happen soon)

alonisser commented 7 years ago

Finished and fixed. Sorry for the misunderstanding about deploy/merge

OriHoch commented 7 years ago

cool, thanks!