hasadna / Open-Knesset

A project aimed at making the Israeli Knesset more transparent. Python and Django based
http://oknesset.org/
BSD 3-Clause "New" or "Revised" License
106 stars 175 forks source link

[Blocked] Committee meeting attendees support #842

Open RavivBarzilay opened 7 years ago

RavivBarzilay commented 7 years ago

part of hasadna/knesset-data#143

OriHoch commented 7 years ago

I think some more testing is needed before merging specifically, to test the other parts of this issue in knesset-data-django hasadna/knesset-data-django#13 - and see if any more changes might be needed for the model

alonisser commented 7 years ago

Data migration? tests? public api? unicode methods? Without tests this would contribute to technical debt. without public api, not sure what's the use.. And how are the attendants actually added?

Also adding an attendee that is just a text "name" and text "role" and not a Person, is quite problematic in my view. Would be added with different names, no option to add aggregation functionality on a specific person attending. etc..

OriHoch commented 7 years ago

@alonisser - the goal for this is to have data available via re:dash

if you prefer we can also add it in a different module under knesset-data-django, not as part of open-knesset

but, in this case, due to the relationship with committee meeting it made sense to keep it here

alonisser commented 7 years ago

No problem with keeping it here. Although I do prefer build views or at least an api as an extension task.. redash is very specific. My main problem is saving Queryable data as a text field Instead of a foreign key to an entity