hasadna / avid-covider

MIT License
23 stars 8 forks source link

suggestion: reorder end of flow order #230

Closed noamoss closed 4 years ago

noamoss commented 4 years ago

א. מכיוון שמה שחשוב לנו כדי להצליח זה פחות ״להסתכל במפת התסמינים״ אלא:

  1. שיזכור למלא גם מחר.
  2. שישתף כמה שיותר אנשים. אני חושב שצריך לשנות את הסדר קצת.
noamoss commented 4 years ago

@mushon

pr @244 includes a suggestion to remove the map from the chat flow (as we are automatically redirecting the user to the intro screen). Please review.

the share/reminder order should not change, see the snippet:

image

akariv commented 4 years ago

Please ensure that the final words make sense now that #244 was merged

On Thu, Apr 23, 2020, 01:57 noamoss notifications@github.com wrote:

@mushon https://github.com/mushon

pr @244 https://github.com/244 includes a suggestion to remove the map from the chat flow (as we are automatically redirecting the user to the intro screen).

the share/reminder order should not change, see the snippet:

[image: image] https://user-images.githubusercontent.com/3581741/80041620-92a77480-8505-11ea-9ae3-2e6560bdf798.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/230#issuecomment-618081947, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5LOND5AZ2RHCYGZ3NTRN5Y5FANCNFSM4MOICANQ .

noamoss commented 4 years ago

@maryLoi @mushon I checked it before committing the change, please verify on the test environment.

akariv commented 4 years ago
Screen Shot 2020-04-23 at 11 58 14

Seems that there's a double thank you and a weird sentence (התקרבנו עוד צעד אחד למה?)

noamoss commented 4 years ago

sorry for missing it. pushed a fix.