hasadna / avid-covider

MIT License
23 stars 8 forks source link

refine report end setence #284

Closed noamoss closed 4 years ago

noamoss commented 4 years ago

fixes #228

image

akariv commented 4 years ago

אולי במקום ״יש לנו את כל הדיווח של״, פשוט ״שלחנו את הדיווח של״

On Sun, May 3, 2020 at 3:27 PM noamoss notifications@github.com wrote:

@noamoss https://github.com/noamoss requested your review on: #284 https://github.com/hasadna/avid-covider/pull/284 refine report end setence.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/pull/284#event-3297371311, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5P2F7GDNJYRN33K4STRPVPMPANCNFSM4MYDNERQ .

noamoss commented 4 years ago

מעולה. מתקן עוד רגע

noamoss commented 4 years ago

following Mushon's suggestion:

image

akariv commented 4 years ago

The double question doesn't sound right. Plus, what's the big difference between "סיימנו עם הדיווח של" and "השלמנו את הדיווח היומי עבור" besides using fancier words?

On Sun, May 3, 2020 at 8:56 PM noamoss notifications@github.com wrote:

following Mushon's suggestion:

[image: image] https://user-images.githubusercontent.com/3581741/80921688-8383ba80-8d80-11ea-83ef-601dadf86fe3.png

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/pull/284#issuecomment-623152769, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5LT6K67PDJLIFV2CUDRPWV4ZANCNFSM4MYDNERQ .

noamoss commented 4 years ago

The double question doesn't sound right.

I pretty liked it actually, makes it sound more encouring. @mushon ?

Plus, what's the big difference between "סיימנו עם הדיווח של" and "השלמנו

it does not sound like as final end, like before.

mushon commented 4 years ago

I agree. We don’t need the double question. “השלמנו את הדיווח עבור” - works even if it’s not for the one reporting. Unlike “הדיווח של”