homepage result tab: city / town section

[noamoss]

blocked by #267

Add the following data points to the city/town static image:

• city/town name (with locales, if possible, not a must)
• number of reports
• research prediction
• research prediction compared with last week

בנוסף, אני מציע לוותר על הדרופדאון עם ״הישובים לפי סדר ריכוז התסמינים״ כי ויתרנו על הפונקציה שלו כדרופדאון

[noamoss]

@mushon @akariv

I think we should consider the difference between the local city/town results (this issue) and the map hover data (#306 ) in terms of functionality and displayed data. Please share your thoughts

This is our starting point:

[akariv]

@noamoss all is done apart from the "research prediction" part which we agreed we shouldn't show as a number but design is not updated.

[mushon]

I uploaded a simple style update for the design to fit the current approach: https://zpl.io/VQDpN0m

[mushon]

עדכון אחרון: 13.05

וכן, בואו נוותר על הדגש של השבוע אחורה.

[noamoss]

@mushon

ואת המספר אנחנו עדיין מציגים בעיגול או לא? אדם כתב מוקדם יותר שהיה סיכום שהערך המספרי לא יוצג - אני לא זוכר סיכום כזה, אבל עם הצגת סקאלה (ראה הערה כאן) זה אפשרי מבחינתי.

אם עדיין מציגים את הערך המספרי, אז צריך עדיין להרחיק את התאריך מהערך הנמד, או לפחות שנות מבנה של התאריך- כי שני 13, אחד ליד השני - זה מבלבל.

תוכל לעדכן עיצוב?

[noamoss]

... או סתם לשים את התאריך מתחת לעיגול עם הערך?

[akariv]

@noamoss I think @mushon meant the number in the circle to be the day-of-month (hence the 13). It seems to be confusing. Apart from that, I applied the new design for this section.

[noamoss]

@mushon

It seems to be confusing.

I think it is very confusing. can we leave 13/11/20 (or something similar) out of the dot?

[noamoss]

@mushon please add the updated design (finalized or for discussion), see my recent comments from slack:

א. המקרא מעולה, רק שהוא נראה ממש כמו סרגל שבועי (שורת עיגולים משמא לימין). לדעתי צריך לבדל ביניהם איכשהו.

ב. חושב שכדי להבהיר את משמעות סדר העיגולים בערים צריך לקרב בין הישובים לארצי. הרווח כרגע גדול ומנתק אותם מהסרגל השבועי. או - אולי למקם את סרגל הימים בין הארץ למקומי?

ג. מציע במקום "הישובים לפי סדר ריכוז התסמינים" להחצמד למינוחים המוצגים בעמוד, ולהחליף ל"ישובים וערים לפי רמת התסמינים"

[mushon]

אופציה נוספת מציגה 4 שבועות אחורה:

בנוסף, אני מציע לוותר על הדרופדאון עם ״הישובים לפי סדר ריכוז התסמינים״ כי ויתרנו על הפונקציה שלו כדרופדאון

[noamoss]

@mushon נראה הרבה יותר טוב וחד משמעי בעיני.

@akariv WDYT?

[noamoss]

(@akariv the following parts are relevant both for this issue and for #314, as well):

• [ ] retrieve data for last 30 days fro the last update
• [ ] update the graph, to include/draw 30 circles

notice: to keep it simple and consistent, in case of a missing day/data point, the start date should be 31 days ago, and so on.

[noamoss]

1. city/town names are not following the language ui fallback, for example, when using the Arabic UI:

I am almost sure both Haifa and Beer-Sheva has Arabic names on OSM. If not, we must define a consistent rule.

2. Did not we hear that Nof-Ha'gallil issue was supposed to be solved?

taken on Hebrew UI:

[akariv]

1. There was a bug in the data processing script, so more names should be available now - but OSM still doesn't have all translations for all the cities, so if it's a big problem we should find a solution for this.

2. Nof-Ha'gallil issue was indeed solved, but for the label to appear we need more pixels in the image as explained here: https://github.com/hasadna/avid-covider/issues/267#issuecomment-630948158

Compare: our current image and more pixels

(The second image is too big for our purposes and is only brought here as a demonstration)

[noamoss]

@akariv

1. OSM still doesn't have all translations for all the cities

Arabic looks better, but it is weird Ashkelon does not have an Arabic label. Can you recheck?

I think we can leave as is for now.

2. Nof-Ha'gallil issue was indeed solved, but for the label to appear we need more pixels in the image as explained here: #267 (comment)

not sure I understand the logic, but sounds like no-choice.

3. (new finding):

French UI should show English titles, instead of hebrew:

[akariv]

Good catch on the french - all languages should update soon with more translations.

(e.g. to get arabic we had to match 'petach tikva' and 'petah tiqwa' which wasn't matched before, same for ashkelon and ashqelon)

On Thu, May 21, 2020 at 6:59 PM noamoss notifications@github.com wrote:

@akariv https://github.com/akariv

1. OSM still doesn't have all translations for all the cities

Arabic looks better, but it is weird Ashkelon does not have an Arabic label. Can you recheck?

I think we can leave as is for now.

1. Nof-Ha'gallil issue was indeed solved, but for the label to appear we need more pixels in the image as explained here: #267 https://github.com/hasadna/avid-covider/issues/267 (comment)

not sure I understand the logic, but sounds like no-choice.

1. (new finding):

French UI should show English titles, instead of hebrew:

[image: image] https://user-images.githubusercontent.com/3581741/82578477-20be5b80-9b95-11ea-883b-ace342a7fe37.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/313#issuecomment-632175876, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5ISNRH67KZHFQII4C3RSVFVLANCNFSM4M4XQT2Q .

[akariv]

Okay, all translations are now online - only ones missing are qiriat ono and qiriat tivon. also fixed the dates location on ltr languages which was buggy (but you've seem to have missed that in your screenshot :) )

[noamoss]

looks good.