hompage results tab, national/general dyamic results scale

[noamoss]

part of #215

This part of the results tab should provide the user an indication of the national (avg.) research result

https://app.zeplin.io/project/5e74f33aec70626a34e66595/screen/5ebe979e37cc0746bf7c11dd/ https://app.zeplin.io/project/5e74f33aec70626a34e66595/screen/5ebe97b4b7700e482908a57f/

• [ ] update section heading
• [ ] update scale legend + static label: עדכון אחרון
• [ ] retrieve data for last 30 days fro the last update
• [ ] update the graph, to include/draw 30 circles (national + local). notice: to keep it simple and consistent, in case of a missing day/data point, the start date should be 31 days ago, and so on.
• [ ] add dynamic dates labels to the national graph
• [ ] make it a dynamic property

[noamoss]

@mushon, please finalize

[akariv]

Copying the comment from the channel:

@mushon @noamoss

These are the values for the national “corona-score”:

  #  date                 nr          ws          sr
     (date)        (integer)    (number)    (number)
---  ----------  -----------  ----------  ----------
  1  2020-04-22        81958     69091.2    0.843007
  2  2020-04-23        90181     76422.4    0.847433
  3  2020-04-24        87304     74202.4    0.849931
  4  2020-04-25        85087     72421.3    0.851144
  5  2020-04-26        94121     80149.5    0.851558
  6  2020-04-27        95923     81279.7    0.847343
  7  2020-04-28        80115     66705.5    0.832622
  8  2020-04-29        70072     58157.5    0.829968
  9  2020-04-30        62125     51385.7    0.827134
 10  2020-05-01        60859     50119.9    0.823541
 11  2020-05-02        59458     48994      0.82401
 12  2020-05-03        59528     49440.6    0.830544
 13  2020-05-04        61352     50719.9    0.826703
 14  2020-05-05        63668     52848.6    0.830065
 15  2020-05-06        63383     52989.6    0.836022
 16  2020-05-07        71957     59950      0.833136
 17  2020-05-08        70649     59184.1    0.83772
 18  2020-05-09        69313     58268.4    0.840656

(relevant columns are date, sr (symptoms rate)andnr` (the number of reporters) It all falls in the same level (0.8-0.9), so it will be a little boring (all in the same color). Perhaps a trendline would work better here? Or we remove this altogether?

[noamoss]

I agree.

@mushon ?

[mushon]

I am not sure we need to get into trendlines, it is not the stockmarket where yu may want to catch the right moment to make a decision. The static boring trend tells the right story. A more turbulent trendline may focus the users on the wrong story. Additionally on the neighborhood level I think we will see more turbulent numbers. Don't you think?

[akariv]

@mushon The question was only about the national timeline, which in the past 21 days remained exactly in the same level.

On Tue, May 12, 2020 at 6:01 PM Mushon Zer-Aviv notifications@github.com wrote:

Assigned #314 https://github.com/hasadna/avid-covider/issues/314 to @akariv https://github.com/akariv.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/314#event-3327930151, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5MHVRCJJ3AGPMXYIYDRRFQE5ANCNFSM4M4XTGQQ .

[mushon]

I think the point still stands. If you disagree we can take this discussion to Slack and maybe decide to later scope another task for it.

[noamoss]

@mushon thanks,

1. I assume Monday (07.04) is a date, which should have been 07.05:

2. I got confused between the number in the current report (13) and the date (13.05).

a. Maybe we should show the date closer to the day's name? b. Maybe we should show only the last report date (without the "אתמול" label, which is depended on the ongoing data pipeline)? Can we drop the "a week ago" date?

[akariv]

Since this is still unresolved, I think it might be good to delay this bit till the next version. wdyt @noamoss?

[noamoss]

I agress, but let's hand to @mushon

[noamoss]

(again, the number in the dot is confusing. I would just add a simple date under the current day)

[noamoss]

@mushon please add the relevant design and links

[mushon]

Please refer to the designs here: https://github.com/hasadna/avid-covider/issues/313#issuecomment-630649087

Also available on Zeplin: https://app.zeplin.io/project/5e74f33aec70626a34e66595/screen/5ebe979e37cc0746bf7c11dd/ https://app.zeplin.io/project/5e74f33aec70626a34e66595/screen/5ebe97b4b7700e482908a57f/

[noamoss]

@akariv updated the description, to cover relevant implications of the current issue. I think it is ready to go.

[noamoss]

looks good. verified texts are available on transifex as well.

[noamoss]

@akariv please explain /demonstrate how did you handle this part:

notice: to keep it simple and consistent, in case of a missing day/data point, the start date should be 31 days ago, and so on.

[noamoss]

@akariv what happened to the dotted lines, pointing date --> circle:

[noamoss]

@akariv also need to add ':' for the last update label.

[akariv]

@akariv please explain /demonstrate how did you handle this part:

notice: to keep it simple and consistent, in case of a missing day/data point, the start date should be 31 days ago, and so on.

We only show data for days we have. We always show the last 30 data points. However, based on the way that WIS calculate the data there's no possibility for a missing datapoint.

[akariv]

Dotted lines are in staging (checked on FF and chrome)

[akariv]

need to add ':' for the last update label.

It was removed on purpose as for ltr languages it wouldn't work

[noamoss]

Dotted lines are in staging (checked on FF and chrome)

my screenshot taken on widnows + chrome, on whatismybrowser.com/w/QEF397B

Tried hard refresh, did not solve the issue. It did not reproduce on FF

[akariv]

Tested now on windows w/ chrome 81 and 83, does not reproduce.

[noamoss]

@akariv did you try with the same resolution? (retested, after restarting the device)

[akariv]

In multiple resolutions, including the exact one from the report.

Just to make sure - Are you seeing any console log errors? Are you zoomed in or out? Did you try in an incognito window?

On Thu, May 21, 2020 at 6:43 PM noamoss notifications@github.com wrote:

Assigned #314 https://github.com/hasadna/avid-covider/issues/314 to @akariv https://github.com/akariv.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/314#event-3361199172, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5LUOEVYMLREXP7UDKTRSVD37ANCNFSM4M4XTGQQ .

[akariv]

It was removed on purpose as for ltr languages it wouldn't work

correction: design for this label entirely doesn't work in ltr (falls off the screen). I removed that label for now until a solution in design is provided.

[noamoss]

@akariv

Are you seeing any console log errors?

Are you zoomed in or out?

(nope, default)

Did you try in an incognito window?

yes, problem persists.

Another clue: while using the chrome dev tools (to copy/paste the console.log above) the dotted lines appeared for mobile display, same browser, with 716 X 715:

correction: design for this label entirely doesn't work in ltr (falls off the screen). I removed that label for now until a solution in design is provided.

will open a followup for @mushon to offer a fix (https://github.com/hasadna/avid-covider/issues/335).

[akariv]

So it disappears at some browser width?

On Thu, May 21, 2020 at 7:08 PM noamoss notifications@github.com wrote:

@akariv https://github.com/akariv

Are you seeing any console log errors?

[image: image] https://user-images.githubusercontent.com/3581741/82578786-8c082d80-9b95-11ea-8de6-1b5ed5ffc149.png

Are you zoomed in or out?

(nope, default)

Did you try in an incognito window?

yes, problem persists.

Another clue: while using the chrome dev tools (to copy/paste the console.log above) the dotted lines appeared for mobile display, same browser, with 716 X 715:

[image: image] https://user-images.githubusercontent.com/3581741/82579024-de494e80-9b95-11ea-9f43-0c5f3ee1f565.png

correction: design for this label entirely doesn't work in ltr (falls off the screen). I removed that label for now until a solution in design is provided.

will open a followup for @mushon https://github.com/mushon to offer a fix (#335 https://github.com/hasadna/avid-covider/issues/335).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/314#issuecomment-632180625, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5LLNNKIA3QBPFCAZE3RSVGW3ANCNFSM4M4XTGQQ .

[akariv]

(btw, this is still not mobile display - still desktop, although quite compressed)

On Thu, May 21, 2020 at 7:10 PM Adam Kariv adam.kariv@gmail.com wrote:

So it disappears at some browser width?

On Thu, May 21, 2020 at 7:08 PM noamoss notifications@github.com wrote:

@akariv https://github.com/akariv

Are you seeing any console log errors?

[image: image] https://user-images.githubusercontent.com/3581741/82578786-8c082d80-9b95-11ea-8de6-1b5ed5ffc149.png

Are you zoomed in or out?

(nope, default)

Did you try in an incognito window?

yes, problem persists.

Another clue: while using the chrome dev tools (to copy/paste the console.log above) the dotted lines appeared for mobile display, same browser, with 716 X 715:

[image: image] https://user-images.githubusercontent.com/3581741/82579024-de494e80-9b95-11ea-9f43-0c5f3ee1f565.png

correction: design for this label entirely doesn't work in ltr (falls off the screen). I removed that label for now until a solution in design is provided.

will open a followup for @mushon https://github.com/mushon to offer a fix (#335 https://github.com/hasadna/avid-covider/issues/335).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/314#issuecomment-632180625, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5LLNNKIA3QBPFCAZE3RSVGW3ANCNFSM4M4XTGQQ .

[noamoss]

btw, this is still not mobile display - still desktop, although quite

right

So it disappears at some browser width?

yes, but now it works... did you change anything?

(please notice the :...) ^^^^

[akariv]

I actually pushed a fix ( https://travis-ci.org/github/hasadna/avid-covider/builds/689709616) but it's still building - so no :)

On Thu, May 21, 2020 at 7:19 PM noamoss notifications@github.com wrote:

btw, this is still not mobile display - still desktop, although quite

right

So it disappears at some browser width?

yes, but now it works... did you change anything?

[image: image] https://user-images.githubusercontent.com/3581741/82580587-fb7f1c80-9b97-11ea-9d7f-8fe58311d984.png

(please notice the :...) ^^^^

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/314#issuecomment-632186800, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5LVUXHZ42GH7HYWG4DRSVICXANCNFSM4M4XTGQQ .

[noamoss]

let me know when the : issue (now in rtl) is solved and we can close this issue for good.

[akariv]

Build is brewing ( https://travis-ci.org/github/hasadna/avid-covider/builds/689711747), should be up in a few minutes

On Thu, May 21, 2020 at 7:26 PM noamoss notifications@github.com wrote:

let me know when the : issue (now in rtl) is solved and we can close this issue for good.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/314#issuecomment-632190206, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5NVSPTFFOXXSMWGZ5DRSVI2XANCNFSM4M4XTGQQ .