results tab add link to past data

[noamoss]

(part of #239, #215 )

we would like to enable curious users to download raw past data:

https://github.com/hrossman/Covid19-Survey/tree/master/aggregated_data

[noamoss]

@mushon where/how would you add it?

[akariv]

We should be using our own data repo which is actually usable and has historical data:

https://github.com/hasadna/avid-covider-raw-data

We could link from it to mentioned repo for anyone looking for raw-er undocumented datasets.

On Sat, May 16, 2020, 01:13 noamoss notifications@github.com wrote:

@mushon https://github.com/mushon where/how would you add it?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/325#issuecomment-629524517, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5P62RSHHGLGCGQMCCTRRW5AVANCNFSM4NCTNZ6Q .

[mushon]

https://zpl.io/2EJ9n38

[noamoss]

@mushon I think it is a good position, but:

1. there are two lower buttons with similar colors but different shapes.
2. the current design overemphasizes the ability to download data, over the need to fill the questionnaire, I think it should be simpler :

[akariv]

the main cta is fixed to the bottom, for the download button you will have to scroll down quite a bit

On Tue, May 19, 2020 at 10:12 PM noamoss notifications@github.com wrote:

@mushon https://github.com/mushon I think it is a good position, but:

1. there are two lower buttons with similar colors but different shapes.
2. the current design overemphasizes the ability to download data, over the need to fill the questionnaire, I think it should be simpler :

[image: image] https://user-images.githubusercontent.com/3581741/82368064-72dc7100-9a1d-11ea-96f0-790f5a485a73.png

[image: image] https://user-images.githubusercontent.com/3581741/82367985-4d4f6780-9a1d-11ea-9a75-debc73ed81b4.png

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/325#issuecomment-631025686, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5ON4PGJIEA3YGBWQTDRSLKYDANCNFSM4NCTNZ6Q .

[noamoss]

that's right, but still once we scroll down this button becomes the main item in the page, it takes to focus out of the

1. results
2. start the report button

I guess it is the combination of the size + background color that bothers me. Don't you see an issue here?

[akariv]

There is definitely an issue but it's not crucial I think.

On Tue, May 19, 2020 at 10:32 PM noamoss notifications@github.com wrote:

that's right, but still once we scroll down this button becomes the main item in the page, it takes to focus out of the

1. results
2. start the report button

I guess it is the combination of the size + background color that bothers me. Don't you see an issue here?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/325#issuecomment-631035633, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5LYWZINYK2NHTIHKK3RSLND7ANCNFSM4NCTNZ6Q .

[noamoss]

so let's hope @mushon will be able to make the lightening change in the design before you get to this issue, if not, it's ok to apply as is.

[akariv]

I added it next to the 'source code' link which I think is more appropriate and solves the concerns by @noamoss

[noamoss]

@akariv

I agree.

I am wondering whether we should keep the current link or point directly to https://github.com/hasadna/avid-covider-raw-data/blob/master/input/all_dates.csv, as most of the users aren't familiar with github, and won't find their way to the input/data folder.

Your call.

[akariv]

The link I provided has documentation of the data location and the CSV columns, pointing directly at a csv without any explanation is more confusing imo

[noamoss]

@akariv I think we should also think of Hebrew readers and non-developers, so I suggest to add/update the following lines to the README, and close this issue:

add

להורדת קובץ הנתונים הגולמיים השלם של כל הדיווחים (input/all_dates.csv)

add

To the full raw data csv file, download input/all_dates.csv

update

"All raw data should be uploaded to the input/ directory." --> "All raw data should be uploaded to the input/ directory."

[akariv]

Done.

On Thu, May 21, 2020 at 7:16 PM noamoss notifications@github.com wrote:

@akariv https://github.com/akariv I think we should also think of Hebrew readers and non-developers, so I suggest to add/update the following lines to the README, and close this issue:

add

להורדת https://raw.githubusercontent.com/hasadna/avid-covider-raw-data/master/input/all_dates.csv קובץ הנתונים הגולמיים השלם של כל הדיווחים (input/all_dates.csv https://raw.githubusercontent.com/hasadna/avid-covider-raw-data/master/input/all_dates.csv )

add

To the full raw data csv file, download input/all_dates.csv https://raw.githubusercontent.com/hasadna/avid-covider-raw-data/master/input/all_dates.csv

update

"All raw data should be uploaded to the input/ directory." --> "All raw data should be uploaded to the input/ directory https://github.com/hasadna/avid-covider-raw-data/tree/master/input."

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/325#issuecomment-632185151, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5KGOR3232QCGGOWR2DRSVHXFANCNFSM4NCTNZ6Q .