search

hasadna / avid-covider

MIT License
23 stars 8 forks source link

turn "met X" adult/minor quetsion optional [0.5h] #331

Closed noamoss closed 4 years ago

noamoss commented 4 years ago

part of #308 : following a talk with Smadar, we should turn both questions into optional (not mandatory).

noamoss commented 4 years ago

@akariv tried to voder that in #308: https://github.com/hasadna/avid-covider/pull/308/commits/43c1b67bfd6b7ae4c0a141b915ee521374e09307

akariv commented 4 years ago

Left two comments on the commit: https://github.com/hasadna/avid-covider/commit/43c1b67bfd6b7ae4c0a141b915ee521374e09307

noamoss commented 4 years ago

the placeholder was changed, but I can't click enter with no values on both quetsions

noamoss commented 4 years ago

previous problem solved, but:

send empty field (instead of "0" when the both questions are not being answered:

image

noamoss commented 4 years ago

@akariv now, on first round, things look and behave as expected:

when I enter none, and then going back to correct my answer, the updated value is not being submitted:

תמונה

BTW, did I just submit two reports for the same user by correcting my answer? (two "would send" in the console)

(a fuller check, of possible combinations, will take place later)

noamoss commented 4 years ago

@akariv

  1. please reply my question:

did I just submit two reports for the same user by correcting my answer? (two "would send" in the console)

noamoss commented 4 years ago

@akariv

  1. I am a reproter, 20 years old living with 1 (myself) adult person (in the age of 18+). I reported meeting another 1 adult person, but the submitted value is 2:

תמונה

akariv commented 4 years ago

Can you share the log with the 'household' info?

On Mon, Jun 1, 2020 at 9:31 PM noamoss notifications@github.com wrote:

@akariv https://github.com/akariv

  1. I am a reproter, 20 years old living with 1 (myself) adult person (in the age of 18+). I reported meeting another 1 adult person, but the submitted value is 2:

[image: תמונה] https://user-images.githubusercontent.com/3581741/83441478-4548ec00-a44f-11ea-995a-be0cf9539c07.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/331#issuecomment-637031675, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5POIBWK5DB4LINMRX3RUPXZVANCNFSM4NDSCZAA .

akariv commented 4 years ago

The two would sends is indeed an issue - fixed here: https://travis-ci.org/github/hasadna/avid-covider/builds/693563518

On Mon, Jun 1, 2020 at 9:34 PM Adam Kariv adam.kariv@gmail.com wrote:

Can you share the log with the 'household' info?

On Mon, Jun 1, 2020 at 9:31 PM noamoss notifications@github.com wrote:

@akariv https://github.com/akariv

  1. I am a reproter, 20 years old living with 1 (myself) adult person (in the age of 18+). I reported meeting another 1 adult person, but the submitted value is 2:

[image: תמונה] https://user-images.githubusercontent.com/3581741/83441478-4548ec00-a44f-11ea-995a-be0cf9539c07.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/331#issuecomment-637031675, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5POIBWK5DB4LINMRX3RUPXZVANCNFSM4NDSCZAA .

noamoss commented 4 years ago

@maryLoi

reporter age flatmates > 18 flatmates <18 met > 18 met <18 submitted value <18 submitted value > 18
12 0 0 none none ? ?
20 0 0 none none ? ?
12 1 0 none none ? ?
20 1 0 none none ? ?
12 0 1 none none ? ?
20 0 1 none none ? ?
12 1 1 1 1 ? ?
20 1 1 `1 1 ? ?
noamoss commented 4 years ago

@akariv

Roie is checking the sanity table from the last comment. Will update here soon.

Meanwhile, regardig your last update:

The two would sends is indeed an issue - fixed here...

Tried to reproduce - when I click the "fix/correct" butotn, I fly all the way back to the begnning for the chat - to choose the reporter... was that done on purpose?

akariv commented 4 years ago

If you try.to.correct a previous reporters answer after you started a new reporter, you will restart with the new reporter's answers.

roiezai commented 4 years ago
reporter age flatmates > 18 flatmates <18 met > 18 met <18 submitted value <18 submitted value > 18
12 0 0 none none undefined undefined
20 0 0 none none undefined undefined
12 1 0 none none undefined undefined
20 1 0 none none undefined undefined
12 0 1 none none undefined undefined
20 0 1 none none undefined undefined
12 1 1 1 1 2 2
20 1 1 1 1 2 2
noamoss commented 4 years ago

@akariv

If you try.to.correct a previous reporters answer after you started a new reporter, you will restart with the new reporter's answers.

after finishging the current report, before starting (choosing) the next reporter

akariv commented 4 years ago

yes, in that case you will restart with the reporter choice - as the previous report was already sent and cannot be amended any more.

On Mon, Jun 1, 2020 at 11:56 PM noamoss notifications@github.com wrote:

@akariv https://github.com/akariv

If you try.to.correct a previous reporters answer after you started a new reporter, you will restart with the new reporter's answers.

after finishging the current report, before starting (choosing) the next reporter

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/331#issuecomment-637097147, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5N54VIN65YKWK4O5MLRUQIXNANCNFSM4NDSCZAA .