search

hasadna / avid-covider

MIT License
23 stars 8 forks source link

result tab dates labels on LTR - fix design #335

Open noamoss opened 4 years ago

noamoss commented 4 years ago

https://github.com/hasadna/avid-covider/issues/314#issuecomment-632176307:

design for this label entirely doesn't work in ltr (falls off the screen). I removed that label for now until a solution in design is provided.

image

mushon commented 4 years ago

Group 25 https://zpl.io/aXAAWMg

akariv commented 4 years ago

Yes I considered that but we need to make sure that for other languages the space will fit (esp Russian which is problematic in that sense)

On Fri, May 22, 2020, 19:11 Mushon Zer-Aviv notifications@github.com wrote:

[image: Group 25] https://user-images.githubusercontent.com/27123/82687423-f38aaf80-9c5f-11ea-8962-0b83639406dd.png https://zpl.io/aXAAWMg

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hasadna/avid-covider/issues/335#issuecomment-632772265, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5MPVPUZVINY2KYO6LLRS2P2TANCNFSM4NG6UBNA .

mushon commented 4 years ago

We may want to consider shortened text like updated: and symptoms rate: Additionally on desktop we might want to experiment with a wider graph with larger spacing between the circles.

On another note, I suggest when when we stick this bar to the top we release the fixed title above it. We don’t need both of them to be fixed at the same time.

noamoss commented 4 years ago

@maryLoi can you help with the following labels in Russian?

  1. "updated:"

  2. "symptoms rate:"

Please assign to Adam when done.

maryLoi commented 4 years ago

Updated - обновлено symptoms rate - частота симптомов

noamoss commented 4 years ago

@maryLoi can't you find a shorter/single word term for "midrag"?