hasadna / datacity-k8s

1 stars 0 forks source link

יצירה אוטומטית של ארגונים #101

Closed niryariv closed 3 years ago

niryariv commented 3 years ago

בתור התחלה:

  1. הרשות המקומית הרלבנטית (עיריה?)

  2. מדינת ישראל (פה אני מתייחס לכל המידע שנגרד מתוך דאטה.גוב ואחרים. יכול להיות שנכון יותר שזה יהיה ספק המידע הרלבנטי, למשל המשרד להגנת הסביבה או משרד הפנים וכו׳? מה דעתכם?)

cc @akariv

OriHoch commented 3 years ago

in #97 I added a default organization for the municipality, I think most datasets can be published under that organization. If there are other departments within the municipality (like the public library) they can have their own organization. I don't think scraped data should be under a different organization, I don't think it has any benefit to end-users. Filtering should be done using groups (תחומים) and tags

niryariv commented 3 years ago

להגדיר ארגון עבור כל אחד מפריטי המידע, כדי שהמערכת תייצר אותו בזמן הייבוא

niryariv commented 3 years ago

looking at the CKAN API it seems that we should be able to detect Org (with name, image, url etc) from the package itself, eg: https://opendataprod.br7.org.il/api/3/action/package_show?id=83d232f0-fc41-4638-acb5-2e37b3c5c7ff

But I can't get this to work on data.gov.il. Not sure if I'm missing something or data.gov.il is blocking this or it's a different API version. @OriHoch can you take a look? If this doesn't work I'll maintain it manually in a table instead.

OriHoch commented 3 years ago

yes, it's possible, but I don't think that's necessarily what you want to appear in the target site. for example, the organization for the corona data in odata is "גיא זומר"

OriHoch commented 3 years ago

you don't need to verify this using the CKAN API, you can just access the relevant dataset and see what is the linked organization on the relevant source website

niryariv commented 3 years ago

you don't need to verify this using the CKAN API, you can just access the relevant dataset and see what is the linked organization on the relevant source website

you mean scraping the html?

OriHoch commented 3 years ago

I will use the API

OriHoch commented 3 years ago

please verify for each of the automatically created datasets if the organization from the source will be relevant as-is on the target

if not, which organization to create / use for that dataset

you can see on the source dataset's website the linked organization so you can verify it

akariv commented 3 years ago

Generally speaking I think that we shouldn't rely on the way stuff is organized in data.gov.il, it's quite messy there. Better to have a single organization called 'מאגר מידע ממשלתי' at the moment and be more specific in the future if necessary.

On Wed, Nov 11, 2020 at 2:49 PM Ori Hoch notifications@github.com wrote:

please verify for each of the automatically created datasets if the organization from the source will be relevant as-is on the target

if not, which organization to create / use for that dataset

you can see on the source dataset's website the linked organization so you can verify it

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hasadna/datacity-k8s/issues/101#issuecomment-725405081, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5O2CRCRW2BE5CI6IIDSPKB5RANCNFSM4TGP4Q5A .

niryariv commented 3 years ago

Works for me. @OriHoch let's just hard code מאגר מידע ממשלתי for anything that comes from data.gov.il

What do you guys think we should do with the odata COVID data?

OriHoch commented 3 years ago

no problem, what about logo, description of this organization? you could create this organization on test instance and configure it as an example

akariv commented 3 years ago

https://he.wikipedia.org/wiki/%D7%A1%D7%9E%D7%9C_%D7%9E%D7%93%D7%99%D7%A0%D7%AA_%D7%99%D7%A9%D7%A8%D7%90%D7%9C#/media/%D7%A7%D7%95%D7%91%D7%A5:Emblem_of_Israel.svg

covid data is also government data (as it comes from ministry of health). The question is always about who produced the data, not where we got it from.

On Thu, Nov 12, 2020 at 11:04 AM Ori Hoch notifications@github.com wrote:

no problem, what about logo, description of this organization? you could create this organization on test instance and configure it as an example

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hasadna/datacity-k8s/issues/101#issuecomment-725943694, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5ITWEEFELE4NX7VN5LSPOQLPANCNFSM4TGP4Q5A .

niryariv commented 3 years ago

https://test.datacity.org.il/organization/israel-gov

niryariv commented 3 years ago

closing for #138