search

hasadna / datacity-k8s

1 stars 0 forks source link

editable footer #115

Closed niryariv closed 3 years ago

niryariv commented 3 years ago

We got a request from Kfar Saba (which seems like it be a common need) to add specific links to the footer.

We need a way to do this that is maintainable when we have multiple installations.

Some approaches I've been thinking of:

  1. Add an admin-editable footer block (3 copies, he/en/ar)

  2. Build in a way to add links, in preset 3 columns (user can choose column, edit URL and link text)

  3. Have a city-specific template block in the footer, editable by our devs but not part of the config UI. Have CKAN include the footer when it's working in context of a certain city.

@akariv @OriHoch Thoughts on what's the best approach?

OriHoch commented 3 years ago

it should be configurable, if we expect admin to be able to edit html, then easiest way will be to have a footer links html block for each language, configurable from the datacity settings

niryariv commented 3 years ago

I'm worried users mostly will not know how to edit HTML, and this might let them shoot themselves in the foot too easily. How about option 3 - is it reasonable to implement?

niryariv commented 3 years ago

let's aim for an editable MD field, if we see it's complicated go with HTML

niryariv commented 3 years ago

@OriHoch

  1. ל נראה שהעריכה של השדה הזה נמצאת תחת ״תחומים״ - לא נכון יותר לשים את זה תחת הגדרות?

  2. שיניתי את הערכים בשדה, לא נראה שינוי בפוטר

OriHoch commented 3 years ago
  1. this is managed the same as all other custom datacity instance settings, it will be too complicated to change it
  2. which instance?
niryariv commented 3 years ago

https://kfar-saba.datacity.org.il/

OriHoch commented 3 years ago

I don't see any text in the footer fields image

niryariv commented 3 years ago

because I erased it.. but it works now, I probably put it in the "about" footer by mistake earlier.

The links appear sandwiched between "about" and "api". can we move about/api below, with an empty line between them and the editable footer links? Screen Shot 2020-11-12 at 11 31 45

niryariv commented 3 years ago

@niryariv open new issue

niryariv commented 3 years ago

closing, continue handling in #133