hasadna / datacity-k8s

1 stars 0 forks source link

מאגרי מידע - ארגונים - תחומים #132

Closed niryariv closed 3 years ago

niryariv commented 3 years ago

יחד עם תחומים וארגונים - לשימוש בייבוא בעתיד

אנטנות סלולריות פעילות | מדינת ישראל | https://data.gov.il/dataset/antennaactive | סביבה אנטנות סלולריות בהקמה | מדינת ישראל | https://data.gov.il/dataset/antenna_hakama | סביבה תחנות כיבוי אש | מדינת ישראל | https://data.gov.il/dataset/israel_fire_rescue_stations | בטחון ותשתיות נתוני קורונה ליישוב | מדינת ישראל | https://www.odata.org.il/dataset/adc425d2-7635-425d-9091-4871018f7cb8 | בריאות ורפואה ישיבות | מדינת ישראל | https://data.gov.il/dataset/talmudiccollege | חינוך גני ילדים | מדינת ישראל | https://data.gov.il/dataset/kindergarten | חינוך בתי ספר | מדינת ישראל | https://data.gov.il/dataset/school | חינוך מגרשי חניה | מדינת ישראל | https://data.gov.il/dataset/parkinglots | תחבורה

niryariv commented 3 years ago

@OriHoch moving this to high priority, mainly for the תחומים please make sure the changes apply to maale / rishon / jlm too

OriHoch commented 3 years ago

we don't support updating existing data, this is harder to do as we discussed. I think for already initialized instances it will be easiest to just update manually

niryariv commented 3 years ago

Would deleting everything and reimporting work? Seems quicker than updating manually

OriHoch commented 3 years ago

what are the changes? only the organization and the associated groups?

OriHoch commented 3 years ago
  1. the organization מדינת ישראל does not exist, we talked about it in this task - #101 - but there it is described with a different name, please clarify what needs to be done
  2. some groups are not created automatically or don't match created groups, for example - there is no group "בטחון" and there is no group "תשתיות" - there is a single group "בטחון ותשתיות", also there is no group "איכות סביבה" - please clarify which groups to attach or if you mean to create new groups / modify existing groups?
OriHoch commented 3 years ago

regarding changes to existing data - it will be easiest to modify manually

niryariv commented 3 years ago
1. the organization מדינת ישראל does not exist, we talked about it in this task - #101 - but there it is described with a different name, please clarify what needs to be done

True - changing to מאגר מידע ממשלתי as in https://test.datacity.org.il/organization/israel-gov

2. some groups are not created automatically or don't match created groups, for example - there is no group "בטחון" and there is no group "תשתיות" - there is a single group "בטחון ותשתיות", also there is no group "איכות סביבה" - please clarify which groups to attach or if you mean to create new groups / modify existing groups?

Yes, because the group taxonomy is still fluid. So, if a group exists by the name mentioned, attach to that group. if not, let the user know "Group X does not exist" so they can fix manually

OriHoch commented 3 years ago

this task is meant for instance initialization when the instance is just created, so there is no fluidity in the groups, only the groups created by the instance initialization script will exist

niryariv commented 3 years ago

The fluidity is on our side. Currently we use one set in Maale Adumin, another in Kfar Saba, and we won't have a standard until we launch few more sites and get more real world feedback. So for now it's ok if we have to manually fix a few imports, just need to know which.

I guess there's probably some way in the CKAN UI to find items with no group, if so then no need to output "doesn't exist" in the import process.

niryariv commented 3 years ago

@niryariv fix list to use groups per maale adumim

niryariv commented 3 years ago

@OriHoch עדכנתי את הרשימה למעלה לפי התחומים הקיימים

שים לב שצריך להוסיף אליהם תחום חדש - #139