search

hasadna / datacity-k8s

1 stars 0 forks source link

image size #42

Closed maryLoi closed 3 years ago

maryLoi commented 4 years ago

what is the size of the image bar?

OriHoch commented 4 years ago

what is the image bar?

maryLoi commented 4 years ago

תמונת הרקע הגדולה

OriHoch commented 4 years ago

current image size is 4917 X 1500

https://www.datacity.org.il/wp-content/uploads/2020/08/zagreb.png

akariv commented 4 years ago

This size is too big for any practical use... width should be around 1200px imo, e.g. 1208 x 368 (keeping the same proportions)

On Mon, Aug 10, 2020 at 6:27 PM Ori Hoch notifications@github.com wrote:

current image size is 4917 X 1500

https://www.datacity.org.il/wp-content/uploads/2020/08/zagreb.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hasadna/datacity-k8s/issues/42#issuecomment-671423725, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5N7TOJMLR4SPKMGR5LSAAGXDANCNFSM4PZKJBMQ .

OriHoch commented 4 years ago

I'm not sure how this css works, there are screens with much larger resolution today and also devices with retina display which might show cropped image if resolution is too low

akariv commented 4 years ago

We can set in the css that the image should fit the object its size and not get cropped. 4000px is too much both from a performance point of view (time to load) and from a practical point of view (the human eye can't see such minute details, even with retina displays).

On Mon, Aug 10, 2020 at 8:53 PM Ori Hoch notifications@github.com wrote:

I'm not sure how this css works, there are screens with much larger resolution today and also devices with retina display which might show cropped image if resolution is too low

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hasadna/datacity-k8s/issues/42#issuecomment-671498633, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5JQOAEGN7ERC22WS7LSAAX3FANCNFSM4PZKJBMQ .

niryariv commented 3 years ago

@akariv @OriHoch status? We need this in order to tell the designers what size image is needed

OriHoch commented 3 years ago

this is the image that's used in Maale Adummim - 2560x874 https://www.datacity.org.il/wp-content/uploads/2020/09/Maale_Adumim_panorama_2-scaled.jpg

niryariv commented 3 years ago

@niryariv - check image size best practices w/ designer