using download_knesset_datapackage should work after running datapackage test

[alonisser]

Looks like there is symbolink link for the tests folder? This looks like a mistake I guess?

Traceback:

  File "/home/alonisser/Projects/knesset-data-django/knesset_data_django/common/scrapers/root_datapackage_scraper.py", line 127, in load_from_file
    shutil.rmtree(self.datapackage_dir)
  File "/usr/lib/python2.7/shutil.py", line 232, in rmtree
    onerror(os.path.islink, path, sys.exc_info())
  File "/usr/lib/python2.7/shutil.py", line 230, in rmtree
    raise OSError("Cannot call rmtree on a symbolic link")
OSError: Cannot call rmtree on a symbolic link
(knesset-data-django) ➜  knesset-data-django git:(master) ls data/datapackage
committee-meetings.csv  committee-meetings-protocols  committee-meetings-protocols.csv  committees.csv  members.csv
(knesset-data-django) ➜  knesset-data-django git:(master) ls data/datapackage -al
lrwxrwxrwx 1 alonisser alonisser 89 Jul  8 11:16 data/datapackage -> /home/alonisser/Projects/knesset-data-django/knesset_data_django/common/tests/datapackage

[OriHoch]

the datapackage test made a symbolic link there

but it's not running now, so it shouldn't happen again

you can just delete the data/datapackage symlink

(knesset-data-django) ori@ori-ThinkPad-T560:~/knesset-data-django$ ll data
total 12
drwxr-xr-x 2 ori ori 4096 Jul  8 10:38 ./
drwxr-xr-x 7 ori ori 4096 Jul  8 10:54 ../
-rw-r--r-- 1 ori ori    0 Jul  8 10:30 .gitkeep
lrwxrwxrwx 1 ori ori   74 Jul  8 10:38 datapackage -> /home/ori/knesset-data-django/knesset_data_django/common/tests/datapackage/

[OriHoch]

reproduction

• run the datapackage test (it's skipped at the moment)
• see that it made a symbolic link at data/datapackage
• now run download knesset datapackage e.g. ./manage.py download_knesset_datapackage --url https://s3.amazonaws.com/knesset-data/datapackage_last_5_days_2017-07-08.zip --scrape

expected

• should download and scrape from the datapackage

actual

• OSError: Cannot call rmtree on a symbolic link

[alonisser]

Sure thanks

On Sun, Jul 9, 2017 at 11:19 AM Ori Hoch notifications@github.com wrote:

the datapackage test made a symbolic link there

but it's not running now, so it shouldn't happen again

you can just delete the data/datapackage symlink

(knesset-data-django) ori@ori-ThinkPad-T560:~/knesset-data-django$ ll data total 12 drwxr-xr-x 2 ori ori 4096 Jul 8 10:38 ./ drwxr-xr-x 7 ori ori 4096 Jul 8 10:54 ../ -rw-r--r-- 1 ori ori 0 Jul 8 10:30 .gitkeep lrwxrwxrwx 1 ori ori 74 Jul 8 10:38 datapackage -> /home/ori/knesset-data-django/knesset_data_django/common/tests/datapackage/

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hasadna/knesset-data-django/issues/11#issuecomment-313906166, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXlcLZkvgnOvETl-iTx-dl8gr6mz40iks5sMI0AgaJpZM4OR3Sm .

-- Alon Nisser twitter:@alonisser https://twitter.com/alonisser Facebook https://www.facebook.com/alonisser Tech Blog: https://medium.com/@alonisser/ Personal Blog:degeladom.wordpress.com Tel:972-54-6734469