hasadna / knesset-data-pipelines

Main repository for Open Knesset project - contains the knesset data scrapers and processing pipelines
https://oknesset.org/
MIT License
14 stars 26 forks source link

Incorrect URL Structure in "Link to the broadcast of the meeting on the Knesset website" field in OPEN KNESSET #241

Open yanirmr opened 1 year ago

yanirmr commented 1 year ago

Description

I have identified a problem concerning the URL pattern in the "Link to the broadcast of the meeting on the Knesset website" field in OPEN KNESSET. The current URL structure appears as:

http://main.knesset.gov.il/Activity/committees/Pages/AllCommitteesBroadcast.aspx?TopicID=XXXXX

However, it appears that these URLs are not functioning as expected, resulting in "404 NOT FOUND" errors.

Upon investigation, I have discovered that a different URL structure provides valid links:

https://main.knesset.gov.il/Activity/committees/<Committee_NAME>/Pages/CommitteeTVarchive.aspx?TopicID=XXXXX

For instance, consider the following example:

https://oknesset.org/meetings/2/0/2081120.html

On this page, the current URL link provided is:

http://main.knesset.gov.il/Activity/committees/Pages/AllCommitteesBroadcast.aspx?TopicID=19798

The valid URL, however, would look like this:

https://main.knesset.gov.il/Activity/committees/Insolvency/Pages/CommitteeTVarchive.aspx?TopicID=19798

Steps to Reproduce

  1. Visit the OPEN KNESSET interface and locate the "Link to the broadcast of the meeting on the Knesset website" field.
  2. Select the link provided.
  3. Observe the "404 NOT FOUND" error.

Additional Information

Please note that this issue seems to specifically impact meetings from the 24th and 23rd Knessets. The URL structure for the 25th Knesset appears to be functioning correctly.

OriHoch commented 1 year ago

thanks @yanirmr , looks like it's a problem with the source data we get from the knesset, I sent them an email about it (cc'd you)