add support for yielding exception objects and allowing generator to continue (optional, disabled by default) - Githubissues

hasadna / knesset-data-python

python module that provides api to access Israeli Parliament (Knesset) data

https://github.com/hasadna/knesset-data

1 stars 16 forks source link

add support for yielding exception objects and allowing generator to continue (optional, disabled by default) #2

Closed OriHoch closed 7 years ago

OriHoch commented 7 years ago

reproduction steps

make a call to get some dataservice objects which have an error in parsing / processing one of the items
- for example:
- from knesset_data.dataservice.members import Member
- print(list(Member.get_page()))
- exception raised

expected

support for yielding the exception object instead of raising exception:
- print(list(Member.get_page(skip_exceptions=True)))
- no exception
- results contains both Member objects, and KnessetDataServiceObjectException objects for the problematic objects

actual

raises exception, stopping processing of items