search

hasadna / knesset-data-python

python module that provides api to access Israeli Parliament (Knesset) data
https://github.com/hasadna/knesset-data
1 stars 16 forks source link

Ticket#19 python 2 3 #23

Closed gilwo closed 7 years ago

gilwo commented 7 years ago

apply changes to allow knesset-data-python to run in python2.7 and python3.6

alonisser commented 7 years ago

@gilwo A must when adding compatibility to a language version is adding it to travis-ci test matrix.

alonisser commented 7 years ago

@gilwo Also from the failing tests looks like you didn't add six (And maybe other libs?) to the requirements /setup.py

gilwo commented 7 years ago

@alonisser - i skipped some files from commit, i'll add those in the next batch of commits

alonisser commented 7 years ago

@gilwo I see you got the tests passing, but As far as I can see you didn't add the supported python version to travis test grid, so passing tests could be verified for both supported language versions

OriHoch commented 7 years ago

related issue: #19

gilwo commented 7 years ago

i think this should cover things up