search

hasadna / knesset-data

APIs and documentation to allow getting data from the Israeli Parliament (Knesset)
MIT License
10 stars 12 forks source link

Wrong committee attendance data for MK Michael Malkieli #132

Closed shevyk closed 7 years ago

shevyk commented 7 years ago

MK Michael Malkieli does not appear as having attended committee meetings even though his attendance is recorded in the published protocol. See, for example: https://oknesset.org/committee/meeting/13483/

image image

alonisser commented 7 years ago

@shevyk this is because #133 He can't be in attendance if he is not registered as committee member

OriHoch commented 7 years ago

thanks @alonisser - when I moved the committees scrapers code to knesset-data I don't remember any check of committee memeber.. I'll check again, maybe I missed something

alonisser commented 7 years ago

I don't think there was any, at least for a very long time, the thing is the attendance scraper checks vs the committee members so if the committee members are not updated (BY ADMINISTRATOR) the attendance is wrong

On Tue, Apr 4, 2017 at 12:48 PM Ori Hoch notifications@github.com wrote:

thanks @alonisser https://github.com/alonisser - when I moved the committees scrapers code to knesset-data I don't remember any check of committee memeber.. I'll check again, maybe I missed something

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/hasadna/knesset-data/issues/132#issuecomment-291450220, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXlcAV2Ny18T549lNPOLCKoa9X6bqk6ks5rshH0gaJpZM4Mw5Jw .

-- Alon Nisser twitter:@alonisser https://twitter.com/alonisser Facebook https://www.facebook.com/alonisser Tech Blog: https://medium.com/@alonisser/ Personal Blog:degeladom.wordpress.com Tel:972-54-6734469

OriHoch commented 7 years ago

ok, this is stupid :man_shrugging:

he had an extra space after his name

"מיכאל מלכיאלי "

@alonisser @maryLoi @shevyk

regarding old meetings - I think they will have to be fixed by hand, or in bulk reparse all committee meetings

shevyk commented 7 years ago

Thanks Ori. I think reparsing makes more sense, but only for the last moshav since he joined in November.

On Apr 13, 2017 12:36 PM, "Ori Hoch" notifications@github.com wrote:

ok, this is stupid 🤷‍♂️

he had an extra space after his name

"מיכאל מלכיאלי "

@alonisser https://github.com/alonisser @maryLoi https://github.com/maryLoi @shevyk https://github.com/shevyk

regarding old meetings - I think they will have to be fixed by hand, or in bulk reparse all committee meetings

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hasadna/knesset-data/issues/132#issuecomment-293841250, or mute the thread https://github.com/notifications/unsubscribe-auth/AMHcTVtqOwDT0zxqMYgi2tryqfzOP40sks5rveyngaJpZM4Mw5Jw .

OriHoch commented 7 years ago

it's fixed, I rescraped all meetings of the last moshav also, made sure all MKs don't have spare spaces..