new Knesset API should include data regarding votes

hasadna / knesset-data

APIs and documentation to allow getting data from the Israeli Parliament (Knesset)

MIT License

10 stars 12 forks source link

new Knesset API should include data regarding votes #145

Open OriHoch opened 7 years ago

OriHoch commented 7 years ago

open the new API doc - https://docs.google.com/document/d/1FHqabNsYlSNyul1lArmnONLHnYGA4XQNMs3k-dPgUok/edit
look for data regarding votes

expected

should have votes data
possibly with relation to MKs and bills / laws

actual

no vote data

notes

voting data is still available in the old API - http://knesset.gov.il/Odata/Votes.svc/

OriHoch commented 7 years ago

@maryLoi @shevyk please notify Knesset

OriHoch commented 7 years ago

related issue: #135

alonisser commented 7 years ago

@OriHoch I think @shevyk and me discussed and explained this in slack before. The team responsible for the new hakika api has no connection or authority over votes. The new api for hakika is because the team lead is responsible for maagar hakika leumi. BTW also in the old api there is a workaround for the problem you encountered for wrong vote results. I'll try to find it again

Please close this. since currently this is as designed

OriHoch commented 7 years ago

I guess my memory is not so good in my old age.. sorry :older_man:

I think there is still some problem here as the new API has many details other then legislature, and no where in their doc it says it's only for legislature

the API doc even has mention of votes:

למשל הלינק של כל דף של חבר כנסת או קוד הזיהוי של הח"כ ב-ODATA של ההצבעות שונה מזה שנעשה בו שימוש בסנהדרין

@shevyk @maryLoi could you confirm this with Knesset people? Also, if votes are indeed not part of new API, is there also other data not available? Will Knesset keep supporting the old votes API?

OriHoch commented 7 years ago

also, if old votes API is the API knesset would like us to use - then it has some critical bugs (which are why we keep doing some part in HTML scraping..)

alonisser commented 7 years ago

@OriHoch about the api doc It means the Id is different for mk.. in the new system and the old system. the new system exposes a translation table we can use if we need it (and we do)

About the critical bugs, there is a work around besides the html, I didn't implement since I hoped we'll get a better solution, but i've got it working correctly I'll post it here and we can open another issue to migrate the html vote there