better to use single design system (currently project uses both ant and mui)

[shootermv]

currently project uses both ant and mui ui libraries i think we need to choose single library to stick to otherwise project do not have clear design language and also it relays on multiple dependencies (which will be harder to maintain) personally, i think it is better to stick to ant, since project originally started with this design in mind

for example: we can use antd grid system instead of using material grid or: ant library has datepicker and hourpicker components of its own or: using Card antd component

[NoamGaash]

I prefer using MUI, which is more common. Anyway, let's use dependencies as little as possible. If something can be solved using CSS, that's framework agnostic; therefore it's better

[shootermv]

Im also big fan of mui. Im happy to hear we agree about sticking to single ui lib. So ... Thats means lot of work to be done - move every antd things to mui ones(muify)

[NoamGaash]

It can be done in chunks. Anyway, I think it's a low priority

[shootermv]

It is very good point - to have issues proiritzed

On Mon, Oct 30, 2023, 12:38 NoamGaash @.***> wrote:

It can be done in chunks. Anyway, I think it's a low priority

— Reply to this email directly, view it on GitHub https://github.com/hasadna/open-bus-map-search/issues/158#issuecomment-1784911376, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKGMHT2AMPQFCD6EA6JM5LYB57SJAVCNFSM6AAAAAA6URWLUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUHEYTCMZXGY . You are receiving this because you authored the thread.Message ID: @.***>

[NoamGaash]

we have three pinned issues, these are the top priorities (in my opinion)

[SariHop]

@NoamGaash ,אשמח לקחת את המשימה הזו mui לפי הדיון למעלה הבנתי שעלי להיצמד לעיצוב של

[NoamGaash]

יש טיעונים לכאן ולכאן, גם ant וגם mui טובות למטרותינו, אבל שתיהן ביחד זה מיותר. אפשר להיפטר מmui או מant, אבל העיקר שנישאר רק עם אחת מהן :) אז כן - להיצמד לmui יהיה נהדר! תודה רבה על ההירתמות!

[supervxn]

@SariHop nice to meet you and work on the same project :-)