Open NoamGaash opened 8 months ago
heyy @NoamGaash is the issue still open ? I would like to contributre ?
@bilalshaikh292 sure, go ahead! We're accepting pull requests
Hey, I'd love to resolve this Issue 🤩 I assigned myself if that's ok.
@Roni750 sure! good luck :pray:
@NoamGaash Is this still a bug? How to reproduce it?
@oribro STR:
We try fetching https://open-bus-map-search.hasadna.org.il/profile/assets/index-815ef71e.js instead of https://open-bus-map-search.hasadna.org.il/assets/index-815ef71e.js
@NoamGaash
Ok, this is some wild guess, but inside index.tsx we have that getRoutesList component:
Maybe removing the 'profile' prefix would solve this?
Thanks
@oribro I want a better solution, that will allow us to set the base href from env variable.
do you see the problem?
@NoamGaash
would adding a define object with reading the env variable to the vite.config.ts
then reading this like this in the routes index.tsx:
const BASE_URL = import.meta.env.REACT_APP_BASE_URL || '/';
and changing const router to:
const router = createBrowserRouter(routes, { basename: BASE_URL })
be a solution for this issue?
maybe. if it solves the issue, that's great.
Is this issue still relevant? Is it really a "good first issue"? What exactly needs to be done?
@itsoriki see this link - https://open-bus-map-search.hasadna.org.il/profile/1 it's broken. https://github.com/hasadna/open-bus-map-search/issues/329#issuecomment-1927254252 google "base href react" or "base href vite" for more information
seems like we have a problem with the base href:![image](https://github.com/hasadna/open-bus-map-search/assets/11145132/e4b83efd-20f3-41f8-8980-d151f71be405)
https://open-bus-map-search.hasadna.org.il/profile/1