Add logical seperation to graphs

[Haswell-s]

Make the graphs more readable by adding seperators

[Haswell-s]

First of all you can assing me. Secondly I've encountered a backend bug where the hourly data doesn't have a strict 24h structure. Should this issue be addressed on the api?

https://github.com/hasadna/open-bus-map-search/assets/62185136/6eac8a09-2ec8-4bf8-a49f-def9f5b10df1

[NoamGaash]

If I understood the issue correctly, I believe it should be fixed in the FE level - if there are no busses during Shabats and Chags, I expect the timeline to show zeros even in case the server omits this data

[Haswell-s]

understood the issue correctly, I believe it should be fixed in the FE level - if there are no busses during Shabats and Chags, I expect the timeline to show zeros even in case the server omits this data

So am I supposed to show zeros or not?

[NoamGaash]

it depends, if the chart shows percentage, 0/0 can be omitted. otherwise, I think showing zeroes is a good thing

[Haswell-s]

0/0 is when no busses are planed, on shabbats and holidays none are planed and there are no records as a result. On what does it depened? In my opinion, if no records are present it is safe to assume that no one came

[NoamGaash]

I expect that charts that use ratios will have no data points when zero is devided by zero, like happens in excel and google sheet graphs. What do you think?

[Haswell-s]

ohhhh so just leave it blank, it will make the graph choppy and ugly tho. I personally prefer to see the night hours as "no activity" hours opposed to just blank spots (I think of the graph as something like the hourly weather graph, imagine having blanks in that one..)

[Haswell-s]

Plus having it set to 0 is just a way to display no activity, note that the fillers are from 00 of the day to the last recorded point, not to the 00 of the last day (meaning display fillers ONLY until the last recoded point).

Having it set to blanks will make every shabbat, night and lanuch break to be just a huge hole on the graph

[NoamGaash]

@i5x64BIT zero means zero percent - if we had zero actual rides and zero planned rides, you can say 0% and 100% and both options will be wrong. here is a better visualization of how I imagine it https://colab.research.google.com/drive/1lTucMU1XIhp7fpUALPOmdcZMWFelebf_?usp=sharing (days 3&4 are Shabbat/Chag)

[Haswell-s]

Oh yess, I see it now.

[Haswell-s]

I would say I have 2 options then: Removing the gaps - makes x axis inconsistent Keeping the gaps - makes the graph a little unpleasent to look at.

Which one is better in your opinion?

[NoamGaash]

@i5x64BIT see the image - it has no gaps, and the x axis is consistent.

[Haswell-s]

Yeah, but our graph spits data for a whole week, launch breaks included

[NoamGaash]

I don't understand your latest comment