hasadna / open-bus-map-search

open-bus-map-search

https://open-bus-map-search.hasadna.org.il/dashboard

MIT License

49 stars 87 forks source link

feat: add HBarChart variations to stories #669

Closed R894 closed 3 months ago

R894 commented 3 months ago

Summary

Initializes i18n in .preview so that the hebrew text displays
add LinesHBarChart story
add OperatorHbarChart story

NoamGaash commented 3 months ago

Just sharing my thought - do we want our stories to fetch real data? Maybe we should prefer using storybook for components like HBarChart rather then ArrivalByTimeChart, because storybook is an educational resource for new developers about how to use our components, and it's more likely that they will want to reuse generic components

R894 commented 3 months ago

Just sharing my thought - do we want our stories to fetch real data? Maybe we should prefer using storybook for components like HBarChart rather then ArrivalByTimeChart

I agree completely! How about adding the variations of HBarChart? otherwise we can just keep the i18n fix and rename the PR

NoamGaash commented 2 months ago

@all-contributors please add @R894 for code and test

allcontributors[bot] commented 2 months ago

@NoamGaash

I've put up a pull request to add @R894! :tada: