hasadna / open-bus-map-search

open-bus-map-search

https://open-bus-map-search.hasadna.org.il/dashboard

MIT License

48 stars 85 forks source link

refactor: change misleading title of realtime page #740

Closed itsoriki closed 2 months ago

itsoriki commented 2 months ago

Resolves #685

Description

Change misleading title of the realtime page - realtime => time based
Fix typo: דוגמא => דוגמה Hebrew Academy

screenshots

github-actions[bot] commented 2 months ago

Preview: https://s3.amazonaws.com/noam-gaash.co.il/8999446225/open-bus/a4323bc858b611516c73471f7023949684f5b2f7/index.html Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/8999446225/open-bus/a4323bc858b611516c73471f7023949684f5b2f7/storybook/index.html

itsoriki commented 2 months ago

@NoamGaash Prettier did a ton of formatting - that's the reason for the "huge" number of lines changed - if you want the files to stay in the old formatting let me know

Also, the "realtime" term appears in the Json keys too - should I change them as well? (see picture below)

NoamGaash commented 2 months ago

regarding the "realtime" - I think changing it is a good idea. feel free to do so before or after merging this pr