hasadna / open-bus-map-search

open-bus-map-search
https://open-bus-map-search.hasadna.org.il/dashboard
MIT License
48 stars 85 forks source link

feat: beatutify busTooltip & make lineProfilePage actually work #744

Closed itsoriki closed 1 month ago

itsoriki commented 1 month ago

Resolves #543

Description

screenshots

image image image image image image image

github-actions[bot] commented 1 month ago

Preview: https://s3.amazonaws.com/noam-gaash.co.il/9050529430/open-bus/175c8bf7a8428aebbc73c94ab45c9c4c8df8020f/index.html Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/9050529430/open-bus/175c8bf7a8428aebbc73c94ab45c9c4c8df8020f/storybook/index.html

itsoriki commented 1 month ago

@NoamGaash I can't figure out why that one job is failing consistently - No real error is printed to the console... image

NoamGaash commented 1 month ago

@itsoriki yup that's bad let's start with #747

NoamGaash commented 1 month ago

run npm run lint on your branch

itsoriki commented 1 month ago

@NoamGaash Sorry for the "mess" - can you review this PR now that everything has passed?

Btw the @all-contributors friend of ours doesn't seem to care at all about adding me to the contributors list :(

itsoriki commented 1 month ago

That's a great improvement! few suggestions:

  1. I'm not sure that we need the expanding button - what is it good for?
  2. We can consider translating the direction (290 מעלות) to geographic terms (צפון מערב, אזימוט 290)
  3. when the tooltip is too tall. we can add an inner scrollbar or something similar

wdyt?

  1. Removed the expanding button
  2. I'll open a new (good-first) issue for that
  3. Added an inner scrollbar to the BusTooltip
NoamGaash commented 1 month ago

Thank you! :clap:

@all-contributor please add @itsoriki for code :)

NoamGaash commented 1 month ago

maybe @all-contributors please add @itsoriki for code ?

allcontributors[bot] commented 1 month ago

@NoamGaash

I've put up a pull request to add @itsoriki! :tada: