There are two donate buttons at the navbar which show different things

[VSciFlight]

Noticed on the live website of the project right here

These are the buttons I am speaking of.

link: https://open-bus-map-search.hasadna.org.il/dashboard

The right donation button opens a modal which explains how to donate where the left donation button opens the donation page on jgive.co.il. Both of them show "לתרומות" tooltip.

Donation modal when clicking on the right donation button:

JGive website when clicking on the left donation button: https://www.jgive.com/new/he/ils/donation-targets/3268#donation-modal

again, it was noticed on the live website of the project right here: https://open-bus-map-search.hasadna.org.il/dashboard

[NoamGaash]

Thank you for opening this issue! The modal is the better version. So despite both links are valid, converting the sidebar link to open the modal could be great

[iDanVas]

I'll take it if that's ok. I`m from Maakaf group.

[NoamGaash]

Thank you @iDanVas !

:rocket:

[iDanVas]

Thank you @iDanVas !

🚀

I have though how to change the donation button and came up with 3 options.

1. Remove the donation link from the side bar and clone the donation popup below the links.
2. Same as the 1st option but to add it to the links with onclick event that will open the donation window.
3. Change the donation pop-up to page and inside it will be the internal donation and the link to the external donation.

Which one do you prefer?

[VSciFlight]

I think the donation itself should lay within the modal. In terms of UI/UX the user stays within the website and doesn't "wander" outside of it. Eases the flow for the user.

I don't know if it is possible to embed the donation section from the donation website. In case it isn't, the 2nd option is better.

@NoamGaash What do you think?

[NoamGaash]

@iDanVas @VSciFlight I'm not sure I understand your suggestions. The JGive donation section can't be embedded (it's too expensive for us). That's why we have an image that links to the JGive donation page.

Right now we have two ways to make a donation:

• the icon in the header opens a modal
• the sidebar menu item opens a new page (JGive)

We want to change the sidebar menu item so it will open a modal instead of opening the JGive link.

What do I miss here?

[NoamGaash]

One moment. This issue is not even about the sidebar link. We have two buttons. just delete one of them

[NoamGaash]

first place: https://github.com/hasadna/open-bus-map-search/blob/main/src/layout/header/Header.tsx#L23-L25 second place: https://github.com/hasadna/open-bus-map-search/blob/main/src/routes/index.tsx#L104-L123

[supervxn]

@iDanVas נעים להכיר :-) שמחה לעבוד איתך בפרויקט