hasadna / open-bus-map-search

open-bus-map-search

https://open-bus-map-search.hasadna.org.il/dashboard

MIT License

48 stars 85 forks source link

docs: update the public-appeal Hebrew texts #767

Closed NoamGaash closed 1 month ago

NoamGaash commented 1 month ago

Description

## screenshots

github-actions[bot] commented 1 month ago

Preview: https://s3.amazonaws.com/noam-gaash.co.il/9271568462/open-bus/2f97f9276ab80582a84df959c946677aafa59a12/index.html Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/9271568462/open-bus/2f97f9276ab80582a84df959c946677aafa59a12/storybook/index.html

DafnaPundak commented 1 month ago

@NoamGaash Hi Can I pull this branch and fix small typos?

NoamGaash commented 1 month ago

@DafnaPundak sure

DafnaPundak commented 1 month ago

@NoamGaash Is it okay if I merge/approve a PR that I also contributed to? (of course here its a very small thing, I'm just asking about best practices...)

NoamGaash commented 1 month ago

@DafnaPundak most of the time it's ok, as there are two developers who can confirm that the suggested code fits the standards, but it depends on the project, and how sensitive the code changed in the pull request is

NoamGaash commented 1 month ago

Also, thanks for fixing the typos!

NoamGaash commented 1 month ago

@all-contributors please add @DafnaPundak for review

allcontributors[bot] commented 1 month ago

@NoamGaash

I've put up a pull request to add @DafnaPundak! :tada: