search

hasadna / open-bus-map-search

open-bus-map-search
https://open-bus-map-search.hasadna.org.il/dashboard
MIT License
51 stars 90 forks source link

style: several styling and small changes #780

Closed Sicnecher closed 3 months ago

Sicnecher commented 4 months ago

I've noticed obviously that the app has a nice structure and is working but noticed a milion different ways where features could be added and changed in order to make the code and the website even faster and prettier. for now I made some small adjustments, would contribute in the future more.

NoamGaash commented 4 months ago

Hi, welcome to Databus! :partying_face: It's great to see you here. Please notice there are few things that could help us speed up the review process:

  1. please run npm run lint to see lint errors
  2. please change the PR title to start with style: prefix. Using "conventional commit" titles help release-please (our bot) to make the changelog
  3. Consider making this branch & PR from the original repo (I gave you permissions) so preview can be automatically generated
  4. Consider providing before & after screenshots in your PR description

Thank you!

NoamGaash commented 3 months ago

Hi @Sicnecher do you need any help? Please reply if this PR is still relevant

NoamGaash commented 3 months ago

feel free to re-open this pull request