hasadna / open-bus-map-search

open-bus-map-search

https://open-bus-map-search.hasadna.org.il/dashboard

MIT License

48 stars 85 forks source link

chore: add eslint import order rule #781

Closed ArkadiK94 closed 2 weeks ago

ArkadiK94 commented 1 month ago

Description

why: to have order for the imports how: add rule of eslint-plugin-import ## screenshots none

NoamGaash commented 1 month ago

Thank you!

NoamGaash commented 3 weeks ago

@ArkadiK94 feel free to merge

NoamGaash commented 2 weeks ago

@ArkadiK94 do you need any help?

ArkadiK94 commented 2 weeks ago

@NoamGaash Sorry, I missed the notifications, I will handle the conflicts and merge.

ArkadiK94 commented 2 weeks ago

@NoamGaash I handled the conflicts, however, there are three checks that was skipped, is it ok to merge?

NoamGaash commented 2 weeks ago

@ArkadiK94 sure, it's great. We skip making a preview of your changes when you create them from a forked repository because of security concerns. I made a PR yesterday that will allow doing it securely