hasadna / open-bus-map-search

open-bus-map-search

https://open-bus-map-search.hasadna.org.il/dashboard

MIT License

48 stars 85 forks source link

feat: make us SEO compatible (#745) #790

Open EtayZaslavsky opened 3 weeks ago

EtayZaslavsky commented 3 weeks ago

Description

Created sitemap.js script. It creates a sitemap file in public/sitemap.xml dynamically from the url paths in the src/routes/index.tsx file. The urls get a static base_url (https://open-bus-map-search.hasadna.org.il/).
Added "node sitemap.js" to the build process in package.json.
Added the sitemap url to robots.txt.
Added a "/" prefix to one of the urls in src/routes/index.tsx, for the sitemap.xml regex to find it (as all other urls had it).

github-actions[bot] commented 3 weeks ago

Preview: https://s3.amazonaws.com/noam-gaash.co.il/9631367287/open-bus/28/index.html Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/9631367287/open-bus/28/storybook/index.html

EtayZaslavsky commented 3 weeks ago

Didn't pass lint test. My mistake for not testing locally.

supervxn commented 2 weeks ago

I have some experience in SEO, how can I help?

EtayZaslavsky commented 1 week ago

could it be that these tests failed without connection the code i pushed?

NoamGaash commented 1 week ago

yes, there's an error in production right now

EtayZaslavsky commented 1 week ago

Is there still a problem?

NoamGaash commented 1 week ago

let's see. I'll re-run