search

hasadna / open-bus-map-search

open-bus-map-search
https://open-bus-map-search.hasadna.org.il/dashboard
MIT License
48 stars 85 forks source link

feat: Added complaint button, hidden as an easter egg 'complaint'. #791

Closed LiadOvdat5 closed 2 weeks ago

LiadOvdat5 commented 3 weeks ago

New Feature

Description

When opened you can write your info and submit. to show the button, write 'complaint'

screenshots

image image

LiadOvdat5 commented 3 weeks ago

good job! do you need any help with the linting warnings?

Yes I would love that, I have warning on the any in siriRide in the interface

image

what should I put there instead? Or I should just import them as in the BusToolTip (using useEffect at the start)? image

supervxn commented 2 weeks ago

@LiadOvdat5 - the frontend side looks clear and simple. 😺.

supervxn commented 2 weeks ago

Loving the speed here 🙌. Let me know when it's live.

NoamGaash commented 2 weeks ago

@supervxn Once the pull request is merged (you'll probably get a notification about it) the deployment process will start automatically. It takes 10 minutes on average, but sometime (rarely) it gets stuck for about a day

github-actions[bot] commented 2 weeks ago

Preview: https://s3.amazonaws.com/noam-gaash.co.il/9559894563/open-bus/6/index.html Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/9559894563/open-bus/6/storybook/index.html

NoamGaash commented 2 weeks ago

@supervxn From now on previews are also available on forks, so you can see the feature live.

NoamGaash commented 2 weeks ago

@all-contributors please add @LiadOvdat5 for code

allcontributors[bot] commented 2 weeks ago

@NoamGaash

I've put up a pull request to add @LiadOvdat5! :tada:

supervxn commented 2 weeks ago

@supervxn From now on previews are also available on forks, so you can see the feature live.

is this the right fork?

If so, how can I preview (without installing anything)? https://github.com/LiadOvdat5/open-bus-map-search

NoamGaash commented 2 weeks ago

@supervxn have you seen this comment? image https://github.com/hasadna/open-bus-map-search/pull/791#issuecomment-2175075604

supervxn commented 2 weeks ago

Preview: https://s3.amazonaws.com/noam-gaash.co.il/9559894563/open-bus/6/index.html Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/9559894563/open-bus/6/storybook/index.html

I type complaint and nothing happens

NoamGaash commented 2 weeks ago

did you click on a bus icon inside the real-time map page before typing complaint? did you use english keyboard?

NoamGaash commented 2 weeks ago

Also, now when this PR is merged, you can see it on production https://open-bus-map-search.hasadna.org.il/map

supervxn commented 2 weeks ago

Got it! Thanks @LiadOvdat5 - you rock!

BTW: is the form connected to somewhere already?

NoamGaash commented 1 week ago

not yet

supervxn commented 1 week ago

not yet

Phew.