zushar commented 3 weeks ago

…eBasedMapPage I did this as a draft because I want to make all the headlines of all pages before making a change to leave the uniformity of the site

Description

Move the page's explanation into the model to clean the page a bit

Even the pages that have no video can still be done and maximum down the road will make them a video but I think you can definitely make a infrastructure on the page for a video

github-actions[bot] commented 3 weeks ago

Preview: https://s3.amazonaws.com/noam-gaash.co.il/9523580323/open-bus/98f9f316c848339bf6e2e5f106c246e15f007329/index.html Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/9523580323/open-bus/98f9f316c848339bf6e2e5f106c246e15f007329/storybook/index.html

NoamGaash commented 3 weeks ago

side note - https://eyes.applitools.com/app/test-results/00000251684207444242/?accountId=ClQJqzT0PkebrsewHfaQEQ__ I'm not sure why the visual tests are not linked properly. I'll check that later

zushar commented 2 weeks ago

I did not think of that I will do that

בתאריך יום ד׳, 12 ביוני 2024, 14:38, מאת Noam Gaash ‏< @.***>:

@.**** commented on this pull request.

In src/pages/gaps/index.tsx https://github.com/hasadna/open-bus-map-search/pull/794#discussion_r1636310365 :
     {t('gaps_page_title')}
<InfoYoutubeModal

label={t('open_video_about_this_page')}

title={t('gaps_page_description')}

videoUrl=""
what do you mean by destring the element? I meant to say that if the modal component gets no url, it should not render an iframe inside of it

— Reply to this email directly, view it on GitHub https://github.com/hasadna/open-bus-map-search/pull/794#discussion_r1636310365, or unsubscribe https://github.com/notifications/unsubscribe-auth/AX35RNMMWOHC33EKGDXND4LZHAXJRAVCNFSM6AAAAABJDXSLROVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJSG43DQNZYGU . You are receiving this because you authored the thread.Message ID: @.***>

hasadna / open-bus-map-search

refactor: Remove unused Alert component and update video title in Tim… #794

Description

@.**** commented on this pull request.