search

hasadna / open-bus-map-search

open-bus-map-search
https://open-bus-map-search.hasadna.org.il/dashboard
MIT License
48 stars 85 forks source link

fix: remove css override of white background on darkmode #815

Closed YuvalMasada closed 1 week ago

YuvalMasada commented 2 weeks ago

@NoamGaash Fix description: Remove css override for white background that makes text unreadable while on Darkmode

How to test:

  1. Go Dashboard/Gap patterns page
  2. select start date that is earlier than end date.
  3. A new Alert message should appear above the dates picker with validation error.
  4. Change to Dark mode and check that background of the validation error alert is not white and that the message is clear.
github-actions[bot] commented 2 weeks ago

Preview: https://s3.amazonaws.com/noam-gaash.co.il/9555410688/open-bus/bbbf9bca59b3e6dfed8262ecc1e6d1f87b6738ea/index.html Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/9555410688/open-bus/bbbf9bca59b3e6dfed8262ecc1e6d1f87b6738ea/storybook/index.html

NoamGaash commented 2 weeks ago

Thank you!

YuvalMasada commented 1 week ago

@NoamGaash Do you know why this PR is not finishing the checks? The scm/applitools is pending. If there is something that I can do please tell me.

NoamGaash commented 1 week ago

@YuvalMasada when saving new baselines in the main branch, Eyes performs a conflicts check. I've probably misconfigured something, but the potential conflicts doesn't concern me. feel free to merge