Apply code review comments

hasadna / open-bus-map-search

open-bus-map-search

https://open-bus-map-search.hasadna.org.il/dashboard

MIT License

48 stars 85 forks source link

Apply code review comments #817

Open NoamGaash opened 2 weeks ago

NoamGaash commented 2 weeks ago

We're about to merge this PR: https://github.com/hasadna/open-bus-map-search/pull/791

There are some minor improvements that I commented about, and I'm not sure the author of the pull request wants to fix. Never the less, he made a great feature and we want it merged.

Therefore, if anyone would like to proceed and finish up this task, it would be great. See the comments here: https://github.com/hasadna/open-bus-map-search/pull/791

YuvalMasada commented 1 week ago

I'll take it if that's ok. I saw another issue with the size of the modal and I'll fix it too. It needs scroll for y-axis, at least from what I've experienced.

NoamGaash commented 1 week ago

@YuvalMasada thank you!