search

hasadna / open-bus-map-search

open-bus-map-search
https://open-bus-map-search.hasadna.org.il/dashboard
MIT License
56 stars 90 forks source link

Apply code review comments #817

Closed NoamGaash closed 3 months ago

NoamGaash commented 5 months ago

We're about to merge this PR: https://github.com/hasadna/open-bus-map-search/pull/791

There are some minor improvements that I commented about, and I'm not sure the author of the pull request wants to fix. Never the less, he made a great feature and we want it merged.

Therefore, if anyone would like to proceed and finish up this task, it would be great. See the comments here: https://github.com/hasadna/open-bus-map-search/pull/791

YuvalMasada commented 5 months ago

I'll take it if that's ok. I saw another issue with the size of the modal and I'll fix it too. It needs scroll for y-axis, at least from what I've experienced.

NoamGaash commented 5 months ago

@YuvalMasada thank you!

YuvalMasada commented 4 months ago

@NoamGaash Hi, I've made some local changes to this component. I didn't change the functionality, but change the used material-ui component so dark mode will be handled automatically & and also it solves the need for adding scroll bar. I'm adding some screenshot and if that good I'll make new branch for it.

80 percent zoom dark mode 80 percent zoom - light mode 100 percent - dark mode

NoamGaash commented 4 months ago

@YuvalMasada looks great! Where can I see the code? 👏

YuvalMasada commented 4 months ago

@NoamGaash Here -> https://github.com/hasadna/open-bus-map-search/pull/852