search

hasadna / open-bus-map-search

open-bus-map-search
https://open-bus-map-search.hasadna.org.il/dashboard
MIT License
48 stars 85 forks source link

fix: DateSelector selector validation message issues #819

Closed YuvalMasada closed 1 week ago

YuvalMasada commented 2 weeks ago

@NoamGaash I've added 2 short fixes.

  1. For wrong validation message I added a different message for the specific case. The message will pop for min/max, but I think that the max message will never appear( so maybe it would be better to delete it? not 100% sure ).
  2. To make the message re-render when language changed I've extend the useMemo dependency array with t function that should be reassign as the DateSelector component been re-rendered.
github-actions[bot] commented 2 weeks ago

Preview: https://s3.amazonaws.com/noam-gaash.co.il/9585077280/open-bus/16/index.html Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/9585077280/open-bus/16/storybook/index.html

NoamGaash commented 2 weeks ago

Hi @YuvalMasada , I believe you want to make this pull request in the opposite direction (into main from fix/DateSelector_selector_validation_message_issues )

YuvalMasada commented 1 week ago

@NoamGaash Your belief is 100% right :D. Didn't notice. Will try to fix the fix

YuvalMasada commented 1 week ago

wrong merge direction. Created another PR. Closing this one