hasadna / open-bus

:bus: Analysing Israel's public transport data
93 stars 29 forks source link

Config schema #292

Closed TheFrok closed 4 years ago

TheFrok commented 4 years ago

Added JSON Schema validation for config.json and used the schema to generate sphinx doc using sphinx-jsonschema Issue #266

codecov-io commented 4 years ago

Codecov Report

Merging #292 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files           3        3           
  Lines         116      116           
=======================================
  Hits          109      109           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4570490...52ebff2. Read the comment docs.

TheFrok commented 4 years ago

@OrBin the tests fail because I deleted the option to use future_days_count, and I don't know how to change that on the Travis machine config file.

OrBin commented 4 years ago

@OrBin the tests fail because I deleted the option to use future_days_count, and I don't know how to change that on the Travis machine config file.

As you can see in .travis.yml, the configuration is taken from gtfs/gtfs_utils/gtfs_utils/config_example.json. If you removed future_days_count, do so in the configuration example too.

TheFrok commented 4 years ago
[ERROR] Failed to execute goal org.springframework.boot:spring-boot-maven-plugin:2.0.2.RELEASE:repackage (default) on project bus: Execution default of goal org.springframework.boot:spring-boot-maven-plugin:2.0.2.RELEASE:repackage failed: Plugin org.springframework.boot:spring-boot-maven-plugin:2.0.2.RELEASE or one of its dependencies could not be resolved: Could not transfer artifact org.apache.commons:commons-compress:jar:1.14 from/to google-maven-central (https://maven-central.storage-download.googleapis.com/maven2/): GET request of: org/apache/commons/commons-compress/1.14/commons-compress-1.14.jar from google-maven-central failed: Connection reset -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginResolutionException

I don't think that's related to my change

OrBin commented 4 years ago
[ERROR] Failed to execute goal org.springframework.boot:spring-boot-maven-plugin:2.0.2.RELEASE:repackage (default) on project bus: Execution default of goal org.springframework.boot:spring-boot-maven-plugin:2.0.2.RELEASE:repackage failed: Plugin org.springframework.boot:spring-boot-maven-plugin:2.0.2.RELEASE or one of its dependencies could not be resolved: Could not transfer artifact org.apache.commons:commons-compress:jar:1.14 from/to google-maven-central (https://maven-central.storage-download.googleapis.com/maven2/): GET request of: org/apache/commons/commons-compress/1.14/commons-compress-1.14.jar from google-maven-central failed: Connection reset -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginResolutionException

I don't think that's related to my change

You are right, it's in the Java section of the CI. I'll try to look into this/restart the job.