hasadna / open-bus

:bus: Analysing Israel's public transport data
93 stars 29 forks source link

Feature/analyed based on old files #312

Closed TheFrok closed 4 years ago

TheFrok commented 4 years ago

I extracted the downloading code to a few function so it will be easier to edit (still not best) and then added an option to override the date of the source_files so you can now enter any date you would like from the configuration (it sets this date for all the dates in dates_to_analyze)

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@00974bf). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #312   +/-   ##
=========================================
  Coverage          ?   93.96%           
=========================================
  Files             ?        3           
  Lines             ?      116           
  Branches          ?        0           
=========================================
  Hits              ?      109           
  Misses            ?        7           
  Partials          ?        0           
Impacted Files Coverage Δ
gtfs/retriever/gtfs_retrieve_FS.py 85.71% <0.00%> (ø)
gtfs/retriever/tests/test_gtfs_retrieve_FS.py 98.57% <0.00%> (ø)
gtfs/retriever/s3_wrapper_setup.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00974bf...10f45d4. Read the comment docs.

TheFrok commented 4 years ago

@cjer I fixed the typos

OrBin commented 4 years ago

@cjer Can you approve?