search

hasadna / open-shot

A simple, open question and answer site. Shot being an hebrew acronym for Q&A.
http://localshot.org.il
BSD 3-Clause "New" or "Revised" License
9 stars 30 forks source link

Support hebrew usernames in admin #149

Open daonb opened 11 years ago

daonb commented 11 years ago

When editing a user whose username is in hebrew the admin validation fails. Seems like the right way to solve this is be refactoring user.Profile to extend AbstarctUser and change the username field to support hebrew. Problem is, anywhere in the code we use user.profile we have to refactor :-(

specifying a custom user model the line that needs changing a django ticket telling us we need to refactor

(thanks to @MeirKriheli)

danielhers commented 10 years ago

@tbrisker as long as this isn't fixed, the username regex in user/forms.py should be the same as the one in the model.

danielhers commented 10 years ago

Hey, @daonb , but since we have our own django fork now, why not fix the line you mentioned?

tbrisker commented 10 years ago

consider preventing hebrew usernames altogether because of all the problems they create.

danielhers commented 10 years ago

Is this a decision? As I said, we just need to edit user/forms.py for that, I think.

tbrisker commented 10 years ago

I would like input from @daonb @lotan1 - what do you think? This will require renaming and notifying the user who currently have hebrew usernames.

lotan1 commented 10 years ago

its about 20 active usres can we just obligate english string when registering from now on?

2013/10/6 tbrisker notifications@github.com

like inp

tbrisker commented 10 years ago

It might cause problems for the existing users.

daonb commented 10 years ago

@MeirKriheli, @shaib what's your take? can we change our fork to support hebrew usernames? Mayber create a special branch till we do a proper refactor?

lotan1 commented 10 years ago

בנתיים נרשמים עוד משתמשים גם בעברית, אם זו התלבטות, למה לא לפחות לרשום בטופס התחברות שחובה באנגלית? כרגע לא ניתן לשייך מועמדים עם יוזר עברי לרשימות וזה מחייב את השינוי הידני אם הם נרשמים בעצמם.

2013/10/7 benny daon notifications@github.com

@MeirKriheli https://github.com/MeirKriheli, @shaibhttps://github.com/shaibwhat's your take? can we change our fork to support hebrew usernames? Mayber create a special branch till we do a proper refactor?

— Reply to this email directly or view it on GitHubhttps://github.com/hasadna/open-shot/issues/149#issuecomment-25785914 .