hasadna / openmuni-budgets

A web app and web API for storing, accessing, visualizing and comparing budgetary data from Israeli municipalities.
http://openmuni.org.il/
BSD 3-Clause "New" or "Revised" License
15 stars 28 forks source link

Removing more than one line from the graph fails #396

Closed idoivri closed 10 years ago

idoivri commented 10 years ago

Although I try to remove lines from the graph, only the first one is being removed, and afterwards, while in the legend they are absent, they still appear on the graph.

Todo: remove 2+ lines from the graph, not only delete them from the legend... ;-)

dovp commented 10 years ago

First observation: Function draw in TimeLineCharts isn't being called.

Root cause: when 'legends_list.delete' event occurs (chart.js) it calls to render function of UiJet but this function supports only rendering once. Render in Base.js calls a constant first parameter=true, and the next rendering (e.g. removing second/third etc legend) won't be performed

ydaniv commented 10 years ago

fixed